Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(553)

Issue 1875483002: Replace a few calls to VoEHardware with direct calls on the ADM, in WVoMC. (Closed)

Created:
4 years, 8 months ago by the sun
Modified:
4 years, 8 months ago
Reviewers:
ossu
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Replace a few calls to VoEHardware with direct calls on the ADM, in WVoMC. BUG=webrtc:4690 Committed: https://crrev.com/5b5129a2ade0d6790ea38bd8057c83db78b4c8c7 Cr-Commit-Position: refs/heads/master@{#12293}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : Add adm() function #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -37 lines) Patch
M webrtc/media/engine/fakewebrtcvoiceengine.h View 2 chunks +4 lines, -18 lines 0 comments Download
M webrtc/media/engine/webrtcvoiceengine.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/media/engine/webrtcvoiceengine.cc View 1 2 5 chunks +14 lines, -12 lines 0 comments Download
M webrtc/media/engine/webrtcvoiceengine_unittest.cc View 1 6 chunks +23 lines, -7 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
the sun
4 years, 8 months ago (2016-04-07 22:02:22 UTC) #2
the sun
4 years, 8 months ago (2016-04-08 05:32:27 UTC) #4
ossu
Seems fine! LGTM
4 years, 8 months ago (2016-04-08 11:08:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1875483002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1875483002/40001
4 years, 8 months ago (2016-04-08 11:09:05 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-08 12:35:54 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-08 12:36:07 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/5b5129a2ade0d6790ea38bd8057c83db78b4c8c7
Cr-Commit-Position: refs/heads/master@{#12293}

Powered by Google App Engine
This is Rietveld 408576698