Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Issue 1874983003: Add performance tracing to AudioDevice inits. (Closed)

Created:
4 years, 8 months ago by pbos-webrtc
Modified:
4 years, 8 months ago
Reviewers:
henrika_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, audio-team_agora.io, sdk-team_agora.io, peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add performance tracing to AudioDevice inits. Adds tracing to AudioDeviceModuleImpl::InitRecording and AudioDeviceModuleImpl::StartRecording to visualize that they are a significant part of startup time in performance recordings. BUG=webrtc:5723 R=henrika@webrtc.org Committed: https://crrev.com/dda52b9c3ea59b53165f79ef1dfc4e6305a07360 Cr-Commit-Position: refs/heads/master@{#12315}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M webrtc/modules/audio_device/audio_device_impl.cc View 3 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
pbos-webrtc
PTAL
4 years, 8 months ago (2016-04-11 13:54:25 UTC) #1
henrika_webrtc
LGTM Can we check these stats outside Chrome?
4 years, 8 months ago (2016-04-11 14:01:40 UTC) #3
pbos-webrtc
On 2016/04/11 14:01:40, henrika_webrtc wrote: > LGTM > > Can we check these stats outside ...
4 years, 8 months ago (2016-04-11 14:03:29 UTC) #4
pbos-webrtc
Committed patchset #1 (id:1) manually as dda52b9c3ea59b53165f79ef1dfc4e6305a07360 (presubmit successful).
4 years, 8 months ago (2016-04-11 14:04:49 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-11 14:04:52 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dda52b9c3ea59b53165f79ef1dfc4e6305a07360
Cr-Commit-Position: refs/heads/master@{#12315}

Powered by Google App Engine
This is Rietveld 408576698