Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 1871993002: Only generate one CNAME per PeerConnection. (Closed)

Created:
4 years, 8 months ago by Zhi Huang
Modified:
4 years, 7 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Only generate one CNAME per PeerConnection. The CNAME is generated in the PeerConnection constructor and is populated through the MediaSessionOptions. A default cname will be set in the MediaSessionOptions constructor. BUG=webrtc:3431 Committed: https://crrev.com/8f65cdf22b6fd16cc22ba1fe967af38bb28eaac1 Cr-Commit-Position: refs/heads/master@{#12650}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Move GenerateCname() to PeerConnect #

Total comments: 4

Patch Set 3 : Add unit tests in peerconnectioninterface_unittest #

Total comments: 19

Patch Set 4 : Renaming: cname -> rtcp_cname. Modified the peerconnectioninterface unit tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -83 lines) Patch
M webrtc/api/peerconnection.h View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M webrtc/api/peerconnection.cc View 1 2 3 6 chunks +20 lines, -0 lines 0 comments Download
M webrtc/api/peerconnectioninterface_unittest.cc View 1 2 3 2 chunks +49 lines, -0 lines 0 comments Download
M webrtc/pc/mediasession.h View 1 2 3 2 chunks +15 lines, -11 lines 0 comments Download
M webrtc/pc/mediasession.cc View 1 2 3 6 chunks +11 lines, -69 lines 0 comments Download
M webrtc/pc/mediasession_unittest.cc View 1 2 3 4 chunks +9 lines, -3 lines 0 comments Download

Messages

Total messages: 23 (10 generated)
Zhi Huang
4 years, 8 months ago (2016-04-11 19:42:01 UTC) #2
Taylor Brandstetter
This will work in most situations. But what if the application removes all the streams, ...
4 years, 8 months ago (2016-04-11 23:35:36 UTC) #3
pthatcher1
https://codereview.webrtc.org/1871993002/diff/1/webrtc/pc/mediasession.cc File webrtc/pc/mediasession.cc (right): https://codereview.webrtc.org/1871993002/diff/1/webrtc/pc/mediasession.cc#newcode226 webrtc/pc/mediasession.cc:226: // sync_label. This comment is no longer accurate. https://codereview.webrtc.org/1871993002/diff/1/webrtc/pc/mediasession.cc#newcode229 ...
4 years, 8 months ago (2016-04-12 22:43:14 UTC) #4
Zhi Huang
I made the changes as we discussed. Not sure if I made it correctly. More ...
4 years, 8 months ago (2016-04-13 22:35:01 UTC) #7
Taylor Brandstetter
Looks good; this is exactly what I was thinking of. More tests couldn't hurt, though. ...
4 years, 8 months ago (2016-04-13 23:03:06 UTC) #8
Zhi Huang
4 years, 8 months ago (2016-04-15 02:03:20 UTC) #10
Taylor Brandstetter
lgtm
4 years, 8 months ago (2016-04-18 17:29:50 UTC) #11
pthatcher1
https://codereview.webrtc.org/1871993002/diff/40001/webrtc/api/peerconnection.cc File webrtc/api/peerconnection.cc (right): https://codereview.webrtc.org/1871993002/diff/40001/webrtc/api/peerconnection.cc#newcode70 webrtc/api/peerconnection.cc:70: static const int kCnameLength = 16; Can you call ...
4 years, 7 months ago (2016-05-05 18:50:52 UTC) #14
Zhi Huang
https://codereview.webrtc.org/1871993002/diff/40001/webrtc/api/peerconnection.cc File webrtc/api/peerconnection.cc (right): https://codereview.webrtc.org/1871993002/diff/40001/webrtc/api/peerconnection.cc#newcode70 webrtc/api/peerconnection.cc:70: static const int kCnameLength = 16; On 2016/05/05 18:50:51, ...
4 years, 7 months ago (2016-05-06 01:36:53 UTC) #15
pthatcher1
lgtm
4 years, 7 months ago (2016-05-07 00:23:13 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1871993002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1871993002/60001
4 years, 7 months ago (2016-05-07 00:40:49 UTC) #19
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 7 months ago (2016-05-07 01:40:34 UTC) #21
commit-bot: I haz the power
4 years, 7 months ago (2016-05-07 01:40:40 UTC) #23
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/8f65cdf22b6fd16cc22ba1fe967af38bb28eaac1
Cr-Commit-Position: refs/heads/master@{#12650}

Powered by Google App Engine
This is Rietveld 408576698