External VNR speed improvement and more.

External VNR speed improvement.

Improved visual quality with 3x times speed-up.
Change list:
 1. Remove second chance filter in temporal denoising filter to mitigate trailing artifact.
 2. Add swap buffer to save one whole-frame memcpy.
 3. Do noise estimation on every N blocks.
 4. Adopt a faster moving object detection algorithm (change the structure).
 5. Refactor the for loops and PositionCheck().
 6. Refactor the function ReduceFalseDetection (RFD).
 7. Fix a bug in TrailingBlock() which causes a mismatch.
 8. Change unit test to support swap buffer test.
 9. Remove CopyMem8x8, use memcpy to copy U/V plane which can be optimized future.
 10. Remove DenoiseMetrics.

Committed: https://crrev.com/afaae0d15132161a9ef88ade6da9a27d8f9049eb
Cr-Commit-Position: refs/heads/master@{#12340}

[jackychen_, 2016-04-08 21:16:24]

Description was changed from

==========
External VNR speed improvement.

Add swap buffer to save one whole-frame memcpy. Do noise estimation
on every N blocks. Adopt a faster moving object detection algorithm.
==========

to

==========
External VNR speed improvement.

Add swap buffer to save one whole-frame memcpy. Do noise estimation
on every N blocks. Adopt a faster moving object detection algorithm.
==========

[jackychen_, 2016-04-08 21:21:05]

Description was changed from

==========
External VNR speed improvement.

Add swap buffer to save one whole-frame memcpy. Do noise estimation
on every N blocks. Adopt a faster moving object detection algorithm.
==========

to

==========
External VNR speed improvement.

1. Add swap buffer to save one whole-frame memcpy. 
2. Do noise estimation on every N blocks. 
3. Adopt a faster moving object detection algorithm.
==========

[jackychen_, 2016-04-08 21:21:47]

Description was changed from

==========
External VNR speed improvement.

1. Add swap buffer to save one whole-frame memcpy. 
2. Do noise estimation on every N blocks. 
3. Adopt a faster moving object detection algorithm.
==========

to

==========
External VNR speed improvement.

1. Add swap buffer to save one whole-frame memcpy. 
2. Do noise estimation on every N blocks. 
3. Adopt a faster moving object detection algorithm (change the structure).
==========

[jackychen_, 2016-04-08 22:32:20]

jackychen@google.com changed reviewers:
+ marpan@webrtc.org

[jackychen_, 2016-04-08 22:32:52]

Description was changed from

==========
External VNR speed improvement.

1. Add swap buffer to save one whole-frame memcpy. 
2. Do noise estimation on every N blocks. 
3. Adopt a faster moving object detection algorithm (change the structure).
==========

to

==========
External VNR speed improvement.

1. Add swap buffer to save one whole-frame memcpy. 
2. Do noise estimation on every N blocks. 
3. Adopt a faster moving object detection algorithm (change the structure).
4. Refactor the second loop and position check.
==========

[jackychen_, 2016-04-09 00:37:23]

Description was changed from

==========
External VNR speed improvement.

1. Add swap buffer to save one whole-frame memcpy. 
2. Do noise estimation on every N blocks. 
3. Adopt a faster moving object detection algorithm (change the structure).
4. Refactor the second loop and position check.
==========

to

==========
External VNR speed improvement.

1. Add swap buffer to save one whole-frame memcpy. 
2. Do noise estimation on every N blocks. 
3. Adopt a faster moving object detection algorithm (change the structure).
4. Refactor the second loop and position check.
5. Refactor the function ReduceFalseDetection (RFD)
==========

[jackychen_, 2016-04-09 00:39:42]

Description was changed from

==========
External VNR speed improvement.

1. Add swap buffer to save one whole-frame memcpy. 
2. Do noise estimation on every N blocks. 
3. Adopt a faster moving object detection algorithm (change the structure).
4. Refactor the second loop and position check.
5. Refactor the function ReduceFalseDetection (RFD)
==========

to

==========
External VNR speed improvement.

Change list:
 1. Add swap buffer to save one whole-frame memcpy. 
 2. Do noise estimation on every N blocks. 
 3. Adopt a faster moving object detection algorithm (change the structure).
 4. Refactor the second loop and position check.
 5. Refactor the function ReduceFalseDetection (RFD)
==========

[jackychen_, 2016-04-09 00:44:25]

Description was changed from

==========
External VNR speed improvement.

Change list:
 1. Add swap buffer to save one whole-frame memcpy. 
 2. Do noise estimation on every N blocks. 
 3. Adopt a faster moving object detection algorithm (change the structure).
 4. Refactor the second loop and position check.
 5. Refactor the function ReduceFalseDetection (RFD)
==========

to

==========
External VNR speed improvement.

Change list:
 1. Add swap buffer to save one whole-frame memcpy. 
 2. Do noise estimation on every N blocks. 
 3. Adopt a faster moving object detection algorithm (change the structure).
 4. Refactor the second loop and position check.
 5. Refactor the function ReduceFalseDetection (RFD).
==========

[jackychen_, 2016-04-09 02:10:09]

Patchset #4 (id:60001) has been deleted

[jackychen_, 2016-04-09 22:02:03]

Description was changed from

==========
External VNR speed improvement.

Change list:
 1. Add swap buffer to save one whole-frame memcpy. 
 2. Do noise estimation on every N blocks. 
 3. Adopt a faster moving object detection algorithm (change the structure).
 4. Refactor the second loop and position check.
 5. Refactor the function ReduceFalseDetection (RFD).
==========

to

==========
External VNR speed improvement.

Change list:
 1. Add swap buffer to save one whole-frame memcpy. 
 2. Do noise estimation on every N blocks. 
 3. Adopt a faster moving object detection algorithm (change the structure).
 4. Refactor the second loop and position check.
 5. Refactor the function ReduceFalseDetection (RFD).
 6. Fix a bug in TrailingBlock() which causes a mismatch.
 7. Change unit test to support swap buffer test.
==========

[jackychen_, 2016-04-09 23:51:02]

Description was changed from

==========
External VNR speed improvement.

Change list:
 1. Add swap buffer to save one whole-frame memcpy. 
 2. Do noise estimation on every N blocks. 
 3. Adopt a faster moving object detection algorithm (change the structure).
 4. Refactor the second loop and position check.
 5. Refactor the function ReduceFalseDetection (RFD).
 6. Fix a bug in TrailingBlock() which causes a mismatch.
 7. Change unit test to support swap buffer test.
==========

to

==========
External VNR speed improvement.

Change list:
 1. Add swap buffer to save one whole-frame memcpy. 
 2. Do noise estimation on every N blocks. 
 3. Adopt a faster moving object detection algorithm (change the structure).
 4. Refactor the second loop and position check.
 5. Refactor the function ReduceFalseDetection (RFD).
 6. Fix a bug in TrailingBlock() which causes a mismatch.
 7. Change unit test to support swap buffer test.
 8. Remove CopyMem8x8, use memcpy to copy U/V plane which can be optimized
future.
==========

[jackychen_, 2016-04-10 03:03:16]

Description was changed from

==========
External VNR speed improvement.

Change list:
 1. Add swap buffer to save one whole-frame memcpy. 
 2. Do noise estimation on every N blocks. 
 3. Adopt a faster moving object detection algorithm (change the structure).
 4. Refactor the second loop and position check.
 5. Refactor the function ReduceFalseDetection (RFD).
 6. Fix a bug in TrailingBlock() which causes a mismatch.
 7. Change unit test to support swap buffer test.
 8. Remove CopyMem8x8, use memcpy to copy U/V plane which can be optimized
future.
==========

to

==========
External VNR speed improvement.

Change list:
 1. Add swap buffer to save one whole-frame memcpy. 
 2. Do noise estimation on every N blocks. 
 3. Adopt a faster moving object detection algorithm (change the structure).
 4. Refactor the second loop and position check.
 5. Refactor the function ReduceFalseDetection (RFD).
 6. Fix a bug in TrailingBlock() which causes a mismatch.
 7. Change unit test to support swap buffer test.
 8. Remove CopyMem8x8, use memcpy to copy U/V plane which can be optimized
future.
 9. Remove DenoiseMetrics.
==========

[jackychen_, 2016-04-10 05:41:41]

Patchset #8 (id:160001) has been deleted

[jackychen_, 2016-04-10 08:30:50]

Description was changed from

==========
External VNR speed improvement.

Change list:
 1. Add swap buffer to save one whole-frame memcpy. 
 2. Do noise estimation on every N blocks. 
 3. Adopt a faster moving object detection algorithm (change the structure).
 4. Refactor the second loop and position check.
 5. Refactor the function ReduceFalseDetection (RFD).
 6. Fix a bug in TrailingBlock() which causes a mismatch.
 7. Change unit test to support swap buffer test.
 8. Remove CopyMem8x8, use memcpy to copy U/V plane which can be optimized
future.
 9. Remove DenoiseMetrics.
==========

to

==========
External VNR speed improvement.

Change list:
 1. Add swap buffer to save one whole-frame memcpy. 
 2. Do noise estimation on every N blocks. 
 3. Adopt a faster moving object detection algorithm (change the structure).
 4. Refactor the for loops and PositionCheck().
 5. Refactor the function ReduceFalseDetection (RFD).
 6. Fix a bug in TrailingBlock() which causes a mismatch.
 7. Change unit test to support swap buffer test.
 8. Remove CopyMem8x8, use memcpy to copy U/V plane which can be optimized
future.
 9. Remove DenoiseMetrics.
==========

[jackychen_, 2016-04-11 17:00:43]

Description was changed from

==========
External VNR speed improvement.

Change list:
 1. Add swap buffer to save one whole-frame memcpy. 
 2. Do noise estimation on every N blocks. 
 3. Adopt a faster moving object detection algorithm (change the structure).
 4. Refactor the for loops and PositionCheck().
 5. Refactor the function ReduceFalseDetection (RFD).
 6. Fix a bug in TrailingBlock() which causes a mismatch.
 7. Change unit test to support swap buffer test.
 8. Remove CopyMem8x8, use memcpy to copy U/V plane which can be optimized
future.
 9. Remove DenoiseMetrics.
==========

to

==========
External VNR speed improvement.

Improved visual quality with 3x times speed-up, it takes only 10~15% of VP8
encoding time.
Change list:
 1. Remove second chance filter in temporal denoising filter to mitigate
trailing artifact.
 2. Add swap buffer to save one whole-frame memcpy. 
 3. Do noise estimation on every N blocks. 
 4. Adopt a faster moving object detection algorithm (change the structure).
 5. Refactor the for loops and PositionCheck().
 6. Refactor the function ReduceFalseDetection (RFD).
 7. Fix a bug in TrailingBlock() which causes a mismatch.
 8. Change unit test to support swap buffer test.
 9. Remove CopyMem8x8, use memcpy to copy U/V plane which can be optimized
future.
 10. Remove DenoiseMetrics.
==========

[marpan, 2016-04-11 17:07:00]

Description was changed from

==========
External VNR speed improvement.

Improved visual quality with 3x times speed-up, it takes only 10~15% of VP8
encoding time.
Change list:
 1. Remove second chance filter in temporal denoising filter to mitigate
trailing artifact.
 2. Add swap buffer to save one whole-frame memcpy. 
 3. Do noise estimation on every N blocks. 
 4. Adopt a faster moving object detection algorithm (change the structure).
 5. Refactor the for loops and PositionCheck().
 6. Refactor the function ReduceFalseDetection (RFD).
 7. Fix a bug in TrailingBlock() which causes a mismatch.
 8. Change unit test to support swap buffer test.
 9. Remove CopyMem8x8, use memcpy to copy U/V plane which can be optimized
future.
 10. Remove DenoiseMetrics.
==========

to

==========
External VNR speed improvement.

Improved visual quality with 3x times speed-up.
Change list:
 1. Remove second chance filter in temporal denoising filter to mitigate
trailing artifact.
 2. Add swap buffer to save one whole-frame memcpy. 
 3. Do noise estimation on every N blocks. 
 4. Adopt a faster moving object detection algorithm (change the structure).
 5. Refactor the for loops and PositionCheck().
 6. Refactor the function ReduceFalseDetection (RFD).
 7. Fix a bug in TrailingBlock() which causes a mismatch.
 8. Change unit test to support swap buffer test.
 9. Remove CopyMem8x8, use memcpy to copy U/V plane which can be optimized
future.
 10. Remove DenoiseMetrics.
==========

[marpan, 2016-04-11 19:16:43]

marpan@google.com changed reviewers:
+ marpan@google.com

[marpan, 2016-04-11 19:16:44]

https://codereview.webrtc.org/1871853003/diff/150015/webrtc/modules/video_pro...
File webrtc/modules/video_processing/video_denoiser.cc (right):

https://codereview.webrtc.org/1871853003/diff/150015/webrtc/modules/video_pro...
webrtc/modules/video_processing/video_denoiser.cc:23: // Check the mb
position(1: close to the center, 3: close to the border).
fix comment: return 1:..., 2:..., 3:...
and explain in words

https://codereview.webrtc.org/1871853003/diff/150015/webrtc/modules/video_pro...
webrtc/modules/video_processing/video_denoiser.cc:109: #if DISPLAY  // Rectangle
diagnostics
move this block of code #DISPLAY to say the top of file, since
it is not part of the algorithm...it is just for viewing/debugging?

https://codereview.webrtc.org/1871853003/diff/150015/webrtc/modules/video_pro...
webrtc/modules/video_processing/video_denoiser.cc:163: void
VideoDenoiser::DenoiseFrame(const VideoFrame& frame,
optional: this function is still kind of long,
may want to break into a few other functions.

https://codereview.webrtc.org/1871853003/diff/150015/webrtc/modules/video_pro...
webrtc/modules/video_processing/video_denoiser.cc:175: if (width_ !=
frame.width() || height_ != frame.height()) {
maybe this block of code can be separate function: re_alloc_denoiser or
something...(re_alloc/reset due to size change)...

https://codereview.webrtc.org/1871853003/diff/150015/webrtc/modules/video_pro...
webrtc/modules/video_processing/video_denoiser.cc:225: const bool ne_enable =
(mb_index % NOISE_SUBSAMPLE_INTERVAL == 0);
No need to change anything, just curious if its better to use some temporal
sampling and spatial (i.e., 1/2 temporal and 1/4x/1/4 spatial) to get similar
ratio ~1/32?
may want to add TODO to test different sampling strategy...

https://codereview.webrtc.org/1871853003/diff/150015/webrtc/modules/video_pro...
webrtc/modules/video_processing/video_denoiser.cc:250: // since no moving edge
block will be filtered in MbDenoise.
is this always true? what it sumdiff_thresh is set to high value (noise_level =
1), like 448?

https://codereview.webrtc.org/1871853003/diff/150015/webrtc/modules/video_pro...
webrtc/modules/video_processing/video_denoiser.cc:256: uint32_t noise_var =
filter_->Variance16x8(mb_dst_prev, stride_y,
Change comment to?
The variance used in noise estimation is based on the src
block in time t (mb_src) and filtered block in time t-1 (mb_dist_prev).

https://codereview.webrtc.org/1871853003/diff/150015/webrtc/modules/video_pro...
webrtc/modules/video_processing/video_denoiser.cc:261: } else {
is this else connected to if (mb_filter_decision_[mb_index] == FILTER_BLOCK) ?
If so, then mb_dst = source for this else code?

https://codereview.webrtc.org/1871853003/diff/150015/webrtc/modules/video_pro...
webrtc/modules/video_processing/video_denoiser.cc:263: // The variance is used
in MOD, it is based on the filtered blocks in
is this (mb_dst) now the filtered or source for time t?

https://codereview.webrtc.org/1871853003/diff/150015/webrtc/modules/video_pro...
webrtc/modules/video_processing/video_denoiser.cc:277: uint32_t noise_var =
filter_->Variance16x8(
put comment here:
The variance used in noise estimation is based on the src
block in time t (mb_src) and filtered block in time t-1 (mb_dist_prev).

https://codereview.webrtc.org/1871853003/diff/150015/webrtc/modules/video_pro...
webrtc/modules/video_processing/video_denoiser.cc:290: // or may cause trailing
artifacts.
"...if the block may cause...."

https://codereview.webrtc.org/1871853003/diff/150015/webrtc/modules/video_pro...
File webrtc/modules/video_processing/video_denoiser.h (right):

https://codereview.webrtc.org/1871853003/diff/150015/webrtc/modules/video_pro...
webrtc/modules/video_processing/video_denoiser.h:37: std::unique_ptr<uint8_t[]>
d_status_red_;
why not use a better name here? 
does red mean moving edge block?

[jackychen_, 2016-04-12 17:02:53]

https://codereview.webrtc.org/1871853003/diff/150015/webrtc/modules/video_pro...
File webrtc/modules/video_processing/video_denoiser.cc (right):

https://codereview.webrtc.org/1871853003/diff/150015/webrtc/modules/video_pro...
webrtc/modules/video_processing/video_denoiser.cc:23: // Check the mb
position(1: close to the center, 3: close to the border).
On 2016/04/11 19:16:44, marpan wrote:
> fix comment: return 1:..., 2:..., 3:...
> and explain in words

Done.

https://codereview.webrtc.org/1871853003/diff/150015/webrtc/modules/video_pro...
webrtc/modules/video_processing/video_denoiser.cc:109: #if DISPLAY  // Rectangle
diagnostics
On 2016/04/11 19:16:44, marpan wrote:
> move this block of code #DISPLAY to say the top of file, since
> it is not part of the algorithm...it is just for viewing/debugging?

Done.

https://codereview.webrtc.org/1871853003/diff/150015/webrtc/modules/video_pro...
webrtc/modules/video_processing/video_denoiser.cc:163: void
VideoDenoiser::DenoiseFrame(const VideoFrame& frame,
On 2016/04/11 19:16:44, marpan wrote:
> optional: this function is still kind of long,
> may want to break into a few other functions.

Done.

https://codereview.webrtc.org/1871853003/diff/150015/webrtc/modules/video_pro...
webrtc/modules/video_processing/video_denoiser.cc:175: if (width_ !=
frame.width() || height_ != frame.height()) {
On 2016/04/11 19:16:44, marpan wrote:
> maybe this block of code can be separate function: re_alloc_denoiser or
> something...(re_alloc/reset due to size change)...

Done.

https://codereview.webrtc.org/1871853003/diff/150015/webrtc/modules/video_pro...
webrtc/modules/video_processing/video_denoiser.cc:225: const bool ne_enable =
(mb_index % NOISE_SUBSAMPLE_INTERVAL == 0);
On 2016/04/11 19:16:44, marpan wrote:
> No need to change anything, just curious if its better to use some temporal
> sampling and spatial (i.e., 1/2 temporal and 1/4x/1/4 spatial) to get similar
> ratio ~1/32?
> may want to add TODO to test different sampling strategy...

Done.

https://codereview.webrtc.org/1871853003/diff/150015/webrtc/modules/video_pro...
webrtc/modules/video_processing/video_denoiser.cc:250: // since no moving edge
block will be filtered in MbDenoise.
On 2016/04/11 19:16:44, marpan wrote:
> is this always true? what it sumdiff_thresh is set to high value (noise_level
=
> 1), like 448?

Done.

https://codereview.webrtc.org/1871853003/diff/150015/webrtc/modules/video_pro...
webrtc/modules/video_processing/video_denoiser.cc:256: uint32_t noise_var =
filter_->Variance16x8(mb_dst_prev, stride_y,
On 2016/04/11 19:16:44, marpan wrote:
> Change comment to?
> The variance used in noise estimation is based on the src
> block in time t (mb_src) and filtered block in time t-1 (mb_dist_prev).

Done.

https://codereview.webrtc.org/1871853003/diff/150015/webrtc/modules/video_pro...
webrtc/modules/video_processing/video_denoiser.cc:261: } else {
On 2016/04/11 19:16:44, marpan wrote:
> is this else connected to if (mb_filter_decision_[mb_index] == FILTER_BLOCK) ?
> If so, then mb_dst = source for this else code?
> 

It is filtered block.

https://codereview.webrtc.org/1871853003/diff/150015/webrtc/modules/video_pro...
webrtc/modules/video_processing/video_denoiser.cc:263: // The variance is used
in MOD, it is based on the filtered blocks in
On 2016/04/11 19:16:44, marpan wrote:
> is this (mb_dst) now the filtered or source for time t?

Done.

https://codereview.webrtc.org/1871853003/diff/150015/webrtc/modules/video_pro...
webrtc/modules/video_processing/video_denoiser.cc:277: uint32_t noise_var =
filter_->Variance16x8(
On 2016/04/11 19:16:44, marpan wrote:
> put comment here:
> The variance used in noise estimation is based on the src
> block in time t (mb_src) and filtered block in time t-1 (mb_dist_prev).

Done.

https://codereview.webrtc.org/1871853003/diff/150015/webrtc/modules/video_pro...
webrtc/modules/video_processing/video_denoiser.cc:290: // or may cause trailing
artifacts.
On 2016/04/11 19:16:44, marpan wrote:
> "...if the block may cause...."

Done.

https://codereview.webrtc.org/1871853003/diff/150015/webrtc/modules/video_pro...
File webrtc/modules/video_processing/video_denoiser.h (right):

https://codereview.webrtc.org/1871853003/diff/150015/webrtc/modules/video_pro...
webrtc/modules/video_processing/video_denoiser.h:37: std::unique_ptr<uint8_t[]>
d_status_red_;
On 2016/04/11 19:16:44, marpan wrote:
> why not use a better name here? 
> does red mean moving edge block?

Done.

[marpan, 2016-04-12 23:10:19]

lgtm

https://codereview.webrtc.org/1871853003/diff/210001/webrtc/modules/video_pro...
File webrtc/modules/video_processing/util/noise_estimation.cc (right):

https://codereview.webrtc.org/1871853003/diff/210001/webrtc/modules/video_pro...
webrtc/modules/video_processing/util/noise_estimation.cc:51: !num_noisy_block_)
{
is spacing for line 50/51 correct style?

https://codereview.webrtc.org/1871853003/diff/210001/webrtc/modules/video_pro...
File webrtc/modules/video_processing/video_denoiser.h (right):

https://codereview.webrtc.org/1871853003/diff/210001/webrtc/modules/video_pro...
webrtc/modules/video_processing/video_denoiser.h:59: // Moving object detection
(MOD) result.
no need to write "MOD" here? you don't reference it anywhere

[jackychen_, 2016-04-12 23:17:14]

https://codereview.webrtc.org/1871853003/diff/210001/webrtc/modules/video_pro...
File webrtc/modules/video_processing/util/noise_estimation.cc (right):

https://codereview.webrtc.org/1871853003/diff/210001/webrtc/modules/video_pro...
webrtc/modules/video_processing/util/noise_estimation.cc:51: !num_noisy_block_)
{
On 2016/04/12 23:10:19, marpan wrote:
> is spacing for line 50/51 correct style?

Yes. It is the correct style. "git cl format" will correct all style errors
automatically and I checked the style with it.

https://codereview.webrtc.org/1871853003/diff/210001/webrtc/modules/video_pro...
File webrtc/modules/video_processing/video_denoiser.h (right):

https://codereview.webrtc.org/1871853003/diff/210001/webrtc/modules/video_pro...
webrtc/modules/video_processing/video_denoiser.h:59: // Moving object detection
(MOD) result.
On 2016/04/12 23:10:19, marpan wrote:
> no need to write "MOD" here? you don't reference it anywhere

Fixed in patch 11.

[marpan2, 2016-04-12 23:18:32]

lgtm

[jackychen_, 2016-04-12 23:49:43]

The CQ bit was checked by jackychen@google.com

[commit-bot: I haz the power, 2016-04-12 23:49:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1871853003/230001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1871853003/230001

[commit-bot: I haz the power, 2016-04-13 01:05:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-13 01:05:41]

Try jobs failed on following builders:
  win_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[jackychen_, 2016-04-13 05:56:50]

The CQ bit was checked by jackychen@google.com

[commit-bot: I haz the power, 2016-04-13 05:57:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1871853003/230001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1871853003/230001

[commit-bot: I haz the power, 2016-04-13 06:02:58]

Description was changed from

==========
External VNR speed improvement.

Improved visual quality with 3x times speed-up.
Change list:
 1. Remove second chance filter in temporal denoising filter to mitigate
trailing artifact.
 2. Add swap buffer to save one whole-frame memcpy. 
 3. Do noise estimation on every N blocks. 
 4. Adopt a faster moving object detection algorithm (change the structure).
 5. Refactor the for loops and PositionCheck().
 6. Refactor the function ReduceFalseDetection (RFD).
 7. Fix a bug in TrailingBlock() which causes a mismatch.
 8. Change unit test to support swap buffer test.
 9. Remove CopyMem8x8, use memcpy to copy U/V plane which can be optimized
future.
 10. Remove DenoiseMetrics.
==========

to

==========
External VNR speed improvement.

Improved visual quality with 3x times speed-up.
Change list:
 1. Remove second chance filter in temporal denoising filter to mitigate
trailing artifact.
 2. Add swap buffer to save one whole-frame memcpy. 
 3. Do noise estimation on every N blocks. 
 4. Adopt a faster moving object detection algorithm (change the structure).
 5. Refactor the for loops and PositionCheck().
 6. Refactor the function ReduceFalseDetection (RFD).
 7. Fix a bug in TrailingBlock() which causes a mismatch.
 8. Change unit test to support swap buffer test.
 9. Remove CopyMem8x8, use memcpy to copy U/V plane which can be optimized
future.
 10. Remove DenoiseMetrics.
==========

[commit-bot: I haz the power, 2016-04-13 06:03:00]

Committed patchset #11 (id:230001)

[commit-bot: I haz the power, 2016-04-13 06:03:14]

Description was changed from

==========
External VNR speed improvement.

Improved visual quality with 3x times speed-up.
Change list:
 1. Remove second chance filter in temporal denoising filter to mitigate
trailing artifact.
 2. Add swap buffer to save one whole-frame memcpy. 
 3. Do noise estimation on every N blocks. 
 4. Adopt a faster moving object detection algorithm (change the structure).
 5. Refactor the for loops and PositionCheck().
 6. Refactor the function ReduceFalseDetection (RFD).
 7. Fix a bug in TrailingBlock() which causes a mismatch.
 8. Change unit test to support swap buffer test.
 9. Remove CopyMem8x8, use memcpy to copy U/V plane which can be optimized
future.
 10. Remove DenoiseMetrics.
==========

to

==========
External VNR speed improvement.

Improved visual quality with 3x times speed-up.
Change list:
 1. Remove second chance filter in temporal denoising filter to mitigate
trailing artifact.
 2. Add swap buffer to save one whole-frame memcpy.
 3. Do noise estimation on every N blocks.
 4. Adopt a faster moving object detection algorithm (change the structure).
 5. Refactor the for loops and PositionCheck().
 6. Refactor the function ReduceFalseDetection (RFD).
 7. Fix a bug in TrailingBlock() which causes a mismatch.
 8. Change unit test to support swap buffer test.
 9. Remove CopyMem8x8, use memcpy to copy U/V plane which can be optimized
future.
 10. Remove DenoiseMetrics.

Committed: https://crrev.com/afaae0d15132161a9ef88ade6da9a27d8f9049eb
Cr-Commit-Position: refs/heads/master@{#12340}
==========

[commit-bot: I haz the power, 2016-04-13 06:03:15]

Patchset 11 (id:??) landed as
https://crrev.com/afaae0d15132161a9ef88ade6da9a27d8f9049eb
Cr-Commit-Position: refs/heads/master@{#12340}