Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Issue 1871543002: Update default parameters in screenshare_loopback test (Closed)

Created:
4 years, 8 months ago by sprang_webrtc
Modified:
4 years, 8 months ago
Reviewers:
pbos-webrtc
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, the sun, pbos-webrtc, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Update default parameters in screenshare_loopback test They should match the parameters used in the FullStack quality tests, so that it is easier to visualize what we are actually testing. BUG= Committed: https://crrev.com/7169bdae3bc86c70808488b34fc5548c5e821085 Cr-Commit-Position: refs/heads/master@{#12466}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M webrtc/video/screenshare_loopback.cc View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
sprang_webrtc
4 years, 8 months ago (2016-04-07 13:17:00 UTC) #2
pbos-webrtc
rs-lgtm
4 years, 8 months ago (2016-04-11 14:09:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1871543002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1871543002/1
4 years, 8 months ago (2016-04-22 08:58:46 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-22 10:49:03 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 10:49:13 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7169bdae3bc86c70808488b34fc5548c5e821085
Cr-Commit-Position: refs/heads/master@{#12466}

Powered by Google App Engine
This is Rietveld 408576698