Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 1871003002: A few small cleanups of stuff caught by lint (Closed)

Created:
4 years, 8 months ago by ossu
Modified:
4 years, 8 months ago
Reviewers:
kwiberg-webrtc
CC:
webrtc-reviews_webrtc.org, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@remove-old-encode
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

A few small cleanups of stuff caught by lint Committed: https://crrev.com/264087f45a32c67c888869865bc331bb894e7b49 Cr-Commit-Position: refs/heads/master@{#12412}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M webrtc/modules/audio_coding/codecs/mock/mock_audio_encoder.h View 3 chunks +6 lines, -3 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/opus/audio_encoder_opus.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 16 (6 generated)
ossu
Put the cleanups here instead. :)
4 years, 8 months ago (2016-04-08 12:33:23 UTC) #2
kwiberg-webrtc
lgtm Consider changing the commit message to e.g. "A few small cleanups of stuff caught ...
4 years, 8 months ago (2016-04-09 06:41:08 UTC) #3
ossu
Sure. Any special reason for it other than, I guess, consistency?
4 years, 8 months ago (2016-04-11 08:15:19 UTC) #4
kwiberg-webrtc
On 2016/04/11 08:15:19, ossu wrote: > Sure. Any special reason for it other than, I ...
4 years, 8 months ago (2016-04-11 08:23:41 UTC) #6
kwiberg-webrtc
On 2016/04/11 08:23:41, kwiberg-webrtc wrote: > On 2016/04/11 08:15:19, ossu wrote: > > Sure. Any ...
4 years, 8 months ago (2016-04-11 08:25:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1871003002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1871003002/1
4 years, 8 months ago (2016-04-12 10:35:48 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL) win_baremetal on ...
4 years, 8 months ago (2016-04-12 12:36:21 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1871003002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1871003002/1
4 years, 8 months ago (2016-04-18 13:45:31 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-18 15:07:28 UTC) #14
commit-bot: I haz the power
4 years, 8 months ago (2016-04-18 15:07:39 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/264087f45a32c67c888869865bc331bb894e7b49
Cr-Commit-Position: refs/heads/master@{#12412}

Powered by Google App Engine
This is Rietveld 408576698