Fixed rtcp rpsi parsing of invalid packets.

webrtc/modules/rtp_rtcp/source/rtcp_receiver_unittest.cc

Index: webrtc/modules/rtp_rtcp/source/rtcp_receiver_unittest.cc
diff --git a/webrtc/modules/rtp_rtcp/source/rtcp_receiver_unittest.cc b/webrtc/modules/rtp_rtcp/source/rtcp_receiver_unittest.cc
index 507f835bc3fb118e4a1cd1f8a379dc5fd770b0be..bbf7305204c8a8e9c2f29e48f7dc1735d248bb57 100644
--- a/webrtc/modules/rtp_rtcp/source/rtcp_receiver_unittest.cc
+++ b/webrtc/modules/rtp_rtcp/source/rtcp_receiver_unittest.cc
@@ -165,6 +165,41 @@ TEST_F(RtcpReceiverTest, InvalidFeedbackPacketIsIgnored) {
   EXPECT_EQ(0U, rtcp_packet_info_.rtcpPacketTypeFlags);
 }
 

[åsapersson, 2016/04/11 09:22:55]

Would also be good to tests a valid rpsi packet.

[danilchap, 2016/04/11 11:00:31]

Done.

+TEST_F(RtcpReceiverTest, RpsiWithFractionalPaddingIsIgnored) {
+  // Padding size represent fractional number of bytes.
+  const uint8_t kPaddingSizeBits = 0x0b;
+  const uint8_t bad_packet[] = {0x83, RTCPUtility::PT_PSFB, 0, 3,
+                                0x12, 0x34, 0x56, 0x78,
+                                0x98, 0x76, 0x54, 0x32,
+                                kPaddingSizeBits, 0x00, 0x00, 0x00};
+  EXPECT_EQ(0, InjectRtcpPacket(bad_packet, sizeof(bad_packet)));
+  EXPECT_EQ(0U, rtcp_packet_info_.rtcpPacketTypeFlags);
+}
+
+TEST_F(RtcpReceiverTest, RpsiWithTooLargePaddingIsIgnored) {
+  // Padding size exceeds packet size.
+  const uint8_t kPaddingSizeBits = 0xa8;
+  const uint8_t bad_packet[] = {0x83, RTCPUtility::PT_PSFB, 0, 3,
+                                0x12, 0x34, 0x56, 0x78,
+                                0x98, 0x76, 0x54, 0x32,
+                                kPaddingSizeBits, 0x00, 0x00, 0x00};
+  EXPECT_EQ(0, InjectRtcpPacket(bad_packet, sizeof(bad_packet)));
+  EXPECT_EQ(0U, rtcp_packet_info_.rtcpPacketTypeFlags);
+}
+
+// With parsing using rtcp classes this test will make no sense.
+// With current stateful parser this test was failing.
+TEST_F(RtcpReceiverTest, TooHalfValidRpsiAreIgnored) {

[åsapersson, 2016/04/11 09:22:55]

Too->Two

[danilchap, 2016/04/11 11:00:31]

oops, Done

+  const uint8_t bad_packet[] = {0x83, RTCPUtility::PT_PSFB, 0, 2,
+                                0x12, 0x34, 0x56, 0x78,
+                                0x98, 0x76, 0x54, 0x32,
+                                0x83, RTCPUtility::PT_PSFB, 0, 2,
+                                0x12, 0x34, 0x56, 0x78,
+                                0x98, 0x76, 0x54, 0x32};
+  EXPECT_EQ(0, InjectRtcpPacket(bad_packet, sizeof(bad_packet)));
+  EXPECT_EQ(0U, rtcp_packet_info_.rtcpPacketTypeFlags);
+}
+
 TEST_F(RtcpReceiverTest, InjectSrPacket) {
   const uint32_t kSenderSsrc = 0x10203;
   rtcp::SenderReport sr;