Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1870043002: Add histogram stats for average QP per frame for VP9 (for sent video streams): (Closed)

Created:
4 years, 8 months ago by åsapersson
Modified:
4 years, 8 months ago
Reviewers:
stefan-webrtc, mflodman
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, the sun, pbos-webrtc, perkj_webrtc, mflodman, marpan2
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add histogram stats for average QP per frame for VP9 (for sent video streams): - "WebRTC.Video.Encoded.Qp.Vp9" - "WebRTC.Video.Encoded.Qp.Vp9.S0" - "WebRTC.Video.Encoded.Qp.Vp9.S1" - "WebRTC.Video.Encoded.Qp.Vp9.S2" BUG= Committed: https://crrev.com/5265fedffe2839bab0b22a7e782dc9ac38c318d2 Cr-Commit-Position: refs/heads/master@{#12402}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : rebase #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+118 lines, -27 lines) Patch
M webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc View 1 1 chunk +3 lines, -0 lines 2 comments Download
M webrtc/system_wrappers/include/metrics.h View 1 4 chunks +14 lines, -0 lines 0 comments Download
M webrtc/video/send_statistics_proxy.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/video/send_statistics_proxy.cc View 1 2 2 chunks +42 lines, -14 lines 0 comments Download
M webrtc/video/send_statistics_proxy_unittest.cc View 1 5 chunks +57 lines, -12 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
åsapersson
4 years, 8 months ago (2016-04-08 12:16:15 UTC) #5
mflodman
One question, then LGTM. https://codereview.webrtc.org/1870043002/diff/80001/webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc File webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc (right): https://codereview.webrtc.org/1870043002/diff/80001/webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc#newcode698 webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc:698: vpx_codec_control(encoder_, VP8E_GET_LAST_QUANTIZER, &qp); I assume ...
4 years, 8 months ago (2016-04-11 07:00:23 UTC) #6
åsapersson
https://codereview.webrtc.org/1870043002/diff/80001/webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc File webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc (right): https://codereview.webrtc.org/1870043002/diff/80001/webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc#newcode698 webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc:698: vpx_codec_control(encoder_, VP8E_GET_LAST_QUANTIZER, &qp); On 2016/04/11 07:00:23, mflodman wrote: > ...
4 years, 8 months ago (2016-04-11 07:28:15 UTC) #7
stefan-webrtc
lgtm
4 years, 8 months ago (2016-04-18 07:52:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1870043002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1870043002/80001
4 years, 8 months ago (2016-04-18 07:57:49 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:80001)
4 years, 8 months ago (2016-04-18 09:58:52 UTC) #12
commit-bot: I haz the power
4 years, 8 months ago (2016-04-18 09:58:59 UTC) #14
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/5265fedffe2839bab0b22a7e782dc9ac38c318d2
Cr-Commit-Position: refs/heads/master@{#12402}

Powered by Google App Engine
This is Rietveld 408576698