Update prflx candidates' generation when setting ICE credentials.

webrtc/p2p/base/p2ptransportchannel.cc

 /*
  *  Copyright 2004 The WebRTC Project Authors. All rights reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 372 matching lines @@
     // are prioritized over the older ones.
     remote_ice_parameters_.push_back(new_ice);
   }
 
   // Update the pwd of remote candidate if needed.
   for (RemoteCandidate& candidate : remote_candidates_) {
     if (candidate.username() == ice_ufrag && candidate.password().empty()) {
       candidate.set_password(ice_pwd);
     }
   }
-  // We need to update the credentials for any peer reflexive candidates.
+  // We need to update the credentials and generation for any peer reflexive
+  // candidates.
   for (Connection* conn : connections_) {
-    conn->MaybeSetRemoteIceCredentials(ice_ufrag, ice_pwd);
+    conn->MaybeSetRemoteIceCredentialsAndGeneration(remote_ice_parameters_);

[honghaiz3, 2016/04/18 16:12:37]

Why does this need to pass all ice parameters and iterate over all of them?
Isn't it sufficient to just pass the newly added one?

[Taylor Brandstetter, 2016/04/18 23:30:01]

You're right. I don't remember what I was thinking. I updated the CL.

   }
+  // Updating the remote ICE candidate generation could change the sort order.
+  RequestSort();
 }
 
 void P2PTransportChannel::SetRemoteIceMode(IceMode mode) {
   remote_ice_mode_ = mode;
 }
 
 void P2PTransportChannel::SetIceConfig(const IceConfig& config) {
   config_.gather_continually = config.gather_continually;
   LOG(LS_INFO) << "Set gather_continually to " << config_.gather_continually;
 
@@ skipping 1226 matching lines @@
 
   // During the initial state when nothing has been pinged yet, return the first
   // one in the ordered |connections_|.
   return *(std::find_if(connections_.begin(), connections_.end(),
                         [conn1, conn2](Connection* conn) {
                           return conn == conn1 || conn == conn2;
                         }));
 }
 
 }  // namespace cricket