Make QualityScaler not downscale below QVGA.

Make QualityScaler not downscale below QVGA.

Applies to all platforms, not only Android now, 160x90 video looks
awful and there's no real point to going below QVGA.

BUG=webrtc:5678
R=danilchap@webrtc.org
TBR=glaznev@webrtc.org

Committed: https://crrev.com/926dfcdf5e72081ac76e19554ae2af7c2f0537d2
Cr-Commit-Position: refs/heads/master@{#12362}

[pbos-webrtc, 2016-04-07 12:54:45]

PTAL, this reduces platform-specific behavior :)

[danilchap, 2016-04-13 13:56:34]

danilchap@webrtc.org changed reviewers:
+ danilchap@webrtc.org

[danilchap, 2016-04-13 13:56:35]

https://codereview.webrtc.org/1867643003/diff/1/webrtc/modules/video_coding/u...
File webrtc/modules/video_coding/utility/quality_scaler.cc (right):

https://codereview.webrtc.org/1867643003/diff/1/webrtc/modules/video_coding/u...
webrtc/modules/video_coding/utility/quality_scaler.cc:23: // Min x/y dimensions
downscale to, set to not go below QVGA, but with some
Min width/height

https://codereview.webrtc.org/1867643003/diff/1/webrtc/modules/video_coding/u...
File webrtc/modules/video_coding/utility/quality_scaler_unittest.cc (right):

https://codereview.webrtc.org/1867643003/diff/1/webrtc/modules/video_coding/u...
webrtc/modules/video_coding/utility/quality_scaler_unittest.cc:484:
TEST_F(QualityScalerTest, DownscalesTo160x90) {
Test probably should be renamed to DownscalesTo320x180

[pbos-webrtc, 2016-04-13 14:00:09]

PTAL

https://codereview.webrtc.org/1867643003/diff/1/webrtc/modules/video_coding/u...
File webrtc/modules/video_coding/utility/quality_scaler.cc (right):

https://codereview.webrtc.org/1867643003/diff/1/webrtc/modules/video_coding/u...
webrtc/modules/video_coding/utility/quality_scaler.cc:23: // Min x/y dimensions
downscale to, set to not go below QVGA, but with some
On 2016/04/13 13:56:35, danilchap wrote:
> Min width/height

Done.

https://codereview.webrtc.org/1867643003/diff/1/webrtc/modules/video_coding/u...
File webrtc/modules/video_coding/utility/quality_scaler_unittest.cc (right):

https://codereview.webrtc.org/1867643003/diff/1/webrtc/modules/video_coding/u...
webrtc/modules/video_coding/utility/quality_scaler_unittest.cc:484:
TEST_F(QualityScalerTest, DownscalesTo160x90) {
On 2016/04/13 13:56:35, danilchap wrote:
> Test probably should be renamed to DownscalesTo320x180

Done.

[pbos-webrtc, 2016-04-13 14:00:10]

feedback

[pbos-webrtc, 2016-04-13 14:00:17]

Description was changed from

==========
Make QualityScaler not downscale below QVGA.

Applies to all platforms, not only Android now, 160x90 video looks
awful and there's no real point to going below QVGA.

BUG=webrtc:5678
R=stefan@webrtc.org
==========

to

==========
Make QualityScaler not downscale below QVGA.

Applies to all platforms, not only Android now, 160x90 video looks
awful and there's no real point to going below QVGA.

BUG=webrtc:5678
R=danilchap@webrtc.org
==========

[pbos-webrtc, 2016-04-13 14:00:54]

https://codereview.webrtc.org/1867643003/diff/20001/webrtc/api/java/jni/andro...
File webrtc/api/java/jni/androidmediaencoder_jni.cc (right):

https://codereview.webrtc.org/1867643003/diff/20001/webrtc/api/java/jni/andro...
webrtc/api/java/jni/androidmediaencoder_jni.cc:641: // Check if we accumulated
too many frames in encoder input buffers and drop
(Sorry, this is part of a rebase.)

[danilchap, 2016-04-14 09:27:36]

lgtm
just one suggestion:

https://codereview.webrtc.org/1867643003/diff/20001/webrtc/modules/video_codi...
File webrtc/modules/video_coding/utility/quality_scaler.cc (right):

https://codereview.webrtc.org/1867643003/diff/20001/webrtc/modules/video_codi...
webrtc/modules/video_coding/utility/quality_scaler.cc:25: static const int
kMinDownscaleDimension = 160;
May be put kMinDownscaleDimension into the QualityScale class instead of webrtc
namespace.
This way
 there will be no need to redeclare this value in unittests;
 would give code reader hint QualityScaler still has min resolution, it just
can't be set any more.

[pbos-webrtc, 2016-04-14 12:12:59]

fix thresholds to permit QCIF

[pbos-webrtc, 2016-04-14 12:13:16]

https://codereview.webrtc.org/1867643003/diff/20001/webrtc/modules/video_codi...
File webrtc/modules/video_coding/utility/quality_scaler.cc (right):

https://codereview.webrtc.org/1867643003/diff/20001/webrtc/modules/video_codi...
webrtc/modules/video_coding/utility/quality_scaler.cc:25: static const int
kMinDownscaleDimension = 160;
On 2016/04/14 09:27:36, danilchap wrote:
> May be put kMinDownscaleDimension into the QualityScale class instead of
webrtc
> namespace.
> This way
>  there will be no need to redeclare this value in unittests;
>  would give code reader hint QualityScaler still has min resolution, it just
> can't be set any more.

I'll keep it this way for now, since we have more corresponding values that
could be considered separately. Putting them under an anonymous namespace though
for now.

[pbos-webrtc, 2016-04-14 12:14:36]

update test

[pbos-webrtc, 2016-04-14 12:48:06]

Description was changed from

==========
Make QualityScaler not downscale below QVGA.

Applies to all platforms, not only Android now, 160x90 video looks
awful and there's no real point to going below QVGA.

BUG=webrtc:5678
R=danilchap@webrtc.org
==========

to

==========
Make QualityScaler not downscale below QVGA.

Applies to all platforms, not only Android now, 160x90 video looks
awful and there's no real point to going below QVGA.

BUG=webrtc:5678
R=danilchap@webrtc.org
TBR=glaznev@webrtc.org
==========

[pbos-webrtc, 2016-04-14 12:48:06]

pbos@webrtc.org changed reviewers:
+ glaznev@webrtc.org

[pbos-webrtc, 2016-04-14 12:48:23]

Description was changed from

==========
Make QualityScaler not downscale below QVGA.

Applies to all platforms, not only Android now, 160x90 video looks
awful and there's no real point to going below QVGA.

BUG=webrtc:5678
R=danilchap@webrtc.org
TBR=glaznev@webrtc.org
==========

to

==========
Make QualityScaler not downscale below QVGA.

Applies to all platforms, not only Android now, 160x90 video looks
awful and there's no real point to going below QVGA.

BUG=webrtc:5678
R=danilchap@webrtc.org
TBR=glaznev@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/926dfcdf5e72081ac76e19554...
==========

[commit-bot: I haz the power, 2016-04-14 12:48:24]

Description was changed from

==========
Make QualityScaler not downscale below QVGA.

Applies to all platforms, not only Android now, 160x90 video looks
awful and there's no real point to going below QVGA.

BUG=webrtc:5678
R=danilchap@webrtc.org
TBR=glaznev@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/926dfcdf5e72081ac76e19554...
==========

to

==========
Make QualityScaler not downscale below QVGA.

Applies to all platforms, not only Android now, 160x90 video looks
awful and there's no real point to going below QVGA.

BUG=webrtc:5678
R=danilchap@webrtc.org
TBR=glaznev@webrtc.org

Committed: https://crrev.com/926dfcdf5e72081ac76e19554ae2af7c2f0537d2
Cr-Commit-Position: refs/heads/master@{#12362}
==========

[pbos-webrtc, 2016-04-14 12:48:24]

Committed patchset #4 (id:60001) manually as
926dfcdf5e72081ac76e19554ae2af7c2f0537d2 (presubmit successful).

[commit-bot: I haz the power, 2016-04-14 12:48:25]

Patchset 4 (id:??) landed as
https://crrev.com/926dfcdf5e72081ac76e19554ae2af7c2f0537d2
Cr-Commit-Position: refs/heads/master@{#12362}

[AlexG, 2016-04-14 16:38:24]

lgtm