Partial revert of "Don't always downsample to 16kHz in the reverse stream in APM"

This CL is partially reverting the effects that
were added in https://codereview.webrtc.org/1773173002.

The reason for the revert is that for some scenarios
that CL causes problems in the coherence estimate used
in the AEC, which in turn causes echo leakage.

The reason for not reverting the actual CL is that
it would cause subsequent CLs to be reverted as well.
Therefore the choice was made to in this CK
instead revert the effects of that CL.

With the changes in this CL, the behavior is bitexact
to what it was before the CL mentioned above.

TBR=aluebs@webrtc.org

BUG=webrtc:5725
Committed: https://crrev.com/0bf612b3ec2fc1d419e3967ce4afd97a28f4786d
Cr-Commit-Position: refs/heads/master@{#12259}

[peah-webrtc, 2016-04-06 06:20:20]

The CQ bit was checked by peah@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-06 06:20:29]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1867483003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1867483003/1

[commit-bot: I haz the power, 2016-04-06 07:16:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-06 07:16:56]

Dry run: This issue passed the CQ dry run.

[peah-webrtc, 2016-04-06 07:45:43]

peah@webrtc.org changed reviewers:
+ henrik.lundin@webrtc.org

[peah-webrtc, 2016-04-06 07:50:57]

peah@webrtc.org changed reviewers:
+ solenberg@webrtc.org

[the sun, 2016-04-06 08:34:23]

On 2016/04/06 07:50:57, peah-webrtc wrote:

Could you please link to the CL being reverted, and explain why reverting is
needed?

[peah-webrtc, 2016-04-06 08:43:08]

Description was changed from

==========
Revert of Dont always downsample to 16kHz in the reverse stream in APM


BUG=webrtc:5725
==========

to

==========
This CL is reverting the effects that were added in
https://codereview.webrtc.org/1773173002.

The reason for the revert is that for some scenarios
that CL causes problems in the coherence estimate used
in the AEC, which in turn causes echo leakage.





BUG=webrtc:5725
==========

[peah-webrtc, 2016-04-06 08:43:56]

On 2016/04/06 08:43:08, peah-webrtc wrote:
> Description was changed from
> 
> ==========
> Revert of Dont always downsample to 16kHz in the reverse stream in APM
> 
> 
> BUG=webrtc:5725
> ==========
> 
> to
> 
> ==========
> This CL is reverting the effects that were added in
> https://codereview.webrtc.org/1773173002.
> 
> The reason for the revert is that for some scenarios
> that CL causes problems in the coherence estimate used
> in the AEC, which in turn causes echo leakage.
> 
> 
> 
> 
> 
> BUG=webrtc:5725
> ==========

Added description about the underlying reason for the revert and a link to the
CL that is reverted.

[peah-webrtc, 2016-04-06 08:46:23]

Description was changed from

==========
This CL is reverting the effects that were added in
https://codereview.webrtc.org/1773173002.

The reason for the revert is that for some scenarios
that CL causes problems in the coherence estimate used
in the AEC, which in turn causes echo leakage.





BUG=webrtc:5725
==========

to

==========
This CL is reverting the effects that were added in
https://codereview.webrtc.org/1773173002.

The reason for the revert is that for some scenarios
that CL causes problems in the coherence estimate used
in the AEC, which in turn causes echo leakage.

The reason for now reverting the actual CL is that
it would cause subsequent CLs to be reverted as well.
Therefore the choice was made to in this CK
instead revert the effects of that CL.

With the changes in this CL, the behavior is bitexact 
to what it was before the CL mentioned above.





BUG=webrtc:5725
==========

[hlundin-webrtc, 2016-04-06 08:55:40]

This seems to be a *partial* revert of the indicated CL; please state that in
the comment. Also, there is a ' missing in the title.

lgtm

[peah-webrtc, 2016-04-06 09:00:13]

Description was changed from

==========
This CL is reverting the effects that were added in
https://codereview.webrtc.org/1773173002.

The reason for the revert is that for some scenarios
that CL causes problems in the coherence estimate used
in the AEC, which in turn causes echo leakage.

The reason for now reverting the actual CL is that
it would cause subsequent CLs to be reverted as well.
Therefore the choice was made to in this CK
instead revert the effects of that CL.

With the changes in this CL, the behavior is bitexact 
to what it was before the CL mentioned above.





BUG=webrtc:5725
==========

to

==========
This CL is partially reverting the effects that 
were added in https://codereview.webrtc.org/1773173002.

The reason for the revert is that for some scenarios
that CL causes problems in the coherence estimate used
in the AEC, which in turn causes echo leakage.

The reason for not reverting the actual CL is that
it would cause subsequent CLs to be reverted as well.
Therefore the choice was made to in this CK
instead revert the effects of that CL.

With the changes in this CL, the behavior is bitexact 
to what it was before the CL mentioned above.





BUG=webrtc:5725
==========

[the sun, 2016-04-06 09:34:57]

lgtm

https://codereview.webrtc.org/1867483003/diff/1/webrtc/modules/audio_processi...
File webrtc/modules/audio_processing/audio_processing_impl.cc (left):

https://codereview.webrtc.org/1867483003/diff/1/webrtc/modules/audio_processi...
webrtc/modules/audio_processing/audio_processing_impl.cc:369: int rev_proc_rate
= ClosestNativeRate(std::min(
nit: ClosestNativeRate() should be renamed btw, since it finds not the closest
rate, bug the closest *higher* rate...

[peah-webrtc, 2016-04-06 09:36:31]

https://codereview.webrtc.org/1867483003/diff/1/webrtc/modules/audio_processi...
File webrtc/modules/audio_processing/audio_processing_impl.cc (left):

https://codereview.webrtc.org/1867483003/diff/1/webrtc/modules/audio_processi...
webrtc/modules/audio_processing/audio_processing_impl.cc:369: int rev_proc_rate
= ClosestNativeRate(std::min(
On 2016/04/06 09:34:57, the sun wrote:
> nit: ClosestNativeRate() should be renamed btw, since it finds not the closest
> rate, bug the closest *higher* rate...

True. Good point! Ok if I address that in another CL?

[peah-webrtc, 2016-04-06 09:37:27]

Description was changed from

==========
This CL is partially reverting the effects that 
were added in https://codereview.webrtc.org/1773173002.

The reason for the revert is that for some scenarios
that CL causes problems in the coherence estimate used
in the AEC, which in turn causes echo leakage.

The reason for not reverting the actual CL is that
it would cause subsequent CLs to be reverted as well.
Therefore the choice was made to in this CK
instead revert the effects of that CL.

With the changes in this CL, the behavior is bitexact 
to what it was before the CL mentioned above.





BUG=webrtc:5725
==========

to

==========
This CL is partially reverting the effects that 
were added in https://codereview.webrtc.org/1773173002.

The reason for the revert is that for some scenarios
that CL causes problems in the coherence estimate used
in the AEC, which in turn causes echo leakage.

The reason for not reverting the actual CL is that
it would cause subsequent CLs to be reverted as well.
Therefore the choice was made to in this CK
instead revert the effects of that CL.

With the changes in this CL, the behavior is bitexact 
to what it was before the CL mentioned above.



TBR=aluebs@webrtc.org

BUG=webrtc:5725
==========

[peah-webrtc, 2016-04-06 09:46:03]

The CQ bit was checked by peah@webrtc.org

[commit-bot: I haz the power, 2016-04-06 09:46:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1867483003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1867483003/1

[commit-bot: I haz the power, 2016-04-06 09:47:51]

Description was changed from

==========
This CL is partially reverting the effects that 
were added in https://codereview.webrtc.org/1773173002.

The reason for the revert is that for some scenarios
that CL causes problems in the coherence estimate used
in the AEC, which in turn causes echo leakage.

The reason for not reverting the actual CL is that
it would cause subsequent CLs to be reverted as well.
Therefore the choice was made to in this CK
instead revert the effects of that CL.

With the changes in this CL, the behavior is bitexact 
to what it was before the CL mentioned above.



TBR=aluebs@webrtc.org

BUG=webrtc:5725
==========

to

==========
This CL is partially reverting the effects that 
were added in https://codereview.webrtc.org/1773173002.

The reason for the revert is that for some scenarios
that CL causes problems in the coherence estimate used
in the AEC, which in turn causes echo leakage.

The reason for not reverting the actual CL is that
it would cause subsequent CLs to be reverted as well.
Therefore the choice was made to in this CK
instead revert the effects of that CL.

With the changes in this CL, the behavior is bitexact 
to what it was before the CL mentioned above.



TBR=aluebs@webrtc.org

BUG=webrtc:5725
==========

[commit-bot: I haz the power, 2016-04-06 09:47:53]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-04-06 09:47:55]

Description was changed from

==========
This CL is partially reverting the effects that 
were added in https://codereview.webrtc.org/1773173002.

The reason for the revert is that for some scenarios
that CL causes problems in the coherence estimate used
in the AEC, which in turn causes echo leakage.

The reason for not reverting the actual CL is that
it would cause subsequent CLs to be reverted as well.
Therefore the choice was made to in this CK
instead revert the effects of that CL.

With the changes in this CL, the behavior is bitexact 
to what it was before the CL mentioned above.



TBR=aluebs@webrtc.org

BUG=webrtc:5725
==========

to

==========
This CL is partially reverting the effects that
were added in https://codereview.webrtc.org/1773173002.

The reason for the revert is that for some scenarios
that CL causes problems in the coherence estimate used
in the AEC, which in turn causes echo leakage.

The reason for not reverting the actual CL is that
it would cause subsequent CLs to be reverted as well.
Therefore the choice was made to in this CK
instead revert the effects of that CL.

With the changes in this CL, the behavior is bitexact
to what it was before the CL mentioned above.

TBR=aluebs@webrtc.org

BUG=webrtc:5725

Committed: https://crrev.com/0bf612b3ec2fc1d419e3967ce4afd97a28f4786d
Cr-Commit-Position: refs/heads/master@{#12259}
==========

[commit-bot: I haz the power, 2016-04-06 09:47:56]

Patchset 1 (id:??) landed as
https://crrev.com/0bf612b3ec2fc1d419e3967ce4afd97a28f4786d
Cr-Commit-Position: refs/heads/master@{#12259}