Add AEC filter divergence metric to StatsCollector.

Add AEC filter divergence metric to StatsCollector.

A new metric that tells how often the AEC linear filter diverges has been recently introduced, see
https://codereview.webrtc.org/1739993003/

This metric can reflect echo failure and ducking.

In this CL, we add a field in StatsCollector to receive this metric.

BUG=
R=tommi@webrtc.org

Committed: https://crrev.com/2a8a78c905a68935d2ff53355982601e2e083dfa
Cr-Commit-Position: refs/heads/master@{#12282}

[minyue-webrtc, 2016-04-07 12:19:46]

Description was changed from

==========
Add AEC filter divergence metric to StatsCollector.

BUG=
==========

to

==========
Add AEC filter divergence metric to StatsCollector.

A new metric that tells how often the AEC linear filter diverges has been
recently introduced, see 
https://codereview.webrtc.org/1739993003/

This metric can reflect echo failure and ducking.

In this CL, we add a field in StatsCollector to receive this metric.

BUG=
==========

[minyue-webrtc, 2016-04-07 12:19:46]

minyue@webrtc.org changed reviewers:
+ tommi@webrtc.org

[minyue-webrtc, 2016-04-07 12:21:04]

Tommi,

Would you help review this CL?

[tommi, 2016-04-07 13:37:03]

lgtm % fixing order

https://codereview.webrtc.org/1866983002/diff/1/webrtc/api/statstypes.cc
File webrtc/api/statstypes.cc (right):

https://codereview.webrtc.org/1866983002/diff/1/webrtc/api/statstypes.cc#newc...
webrtc/api/statstypes.cc:374: case kStatsValueNameAecDivergentFilterFraction:
looks like we've regressed from the alphabetic order here, but if you could fix
it here so that Aec comes before Audio, that would be good.

https://codereview.webrtc.org/1866983002/diff/1/webrtc/api/statstypes.h
File webrtc/api/statstypes.h (right):

https://codereview.webrtc.org/1866983002/diff/1/webrtc/api/statstypes.h#newco...
webrtc/api/statstypes.h:112: kStatsValueNameAecDivergentFilterFraction,
fix alphabetic sorting

[minyue-webrtc, 2016-04-07 14:01:33]

The CQ bit was checked by minyue@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-07 14:01:39]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1866983002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1866983002/20001

[minyue-webrtc, 2016-04-07 14:29:40]

Thanks for the review! I fixed the alphabetic order regarding my added item. It
is CQ (dry run) now.

https://codereview.webrtc.org/1866983002/diff/1/webrtc/api/statstypes.cc
File webrtc/api/statstypes.cc (right):

https://codereview.webrtc.org/1866983002/diff/1/webrtc/api/statstypes.cc#newc...
webrtc/api/statstypes.cc:374: case kStatsValueNameAecDivergentFilterFraction:
On 2016/04/07 13:37:02, tommi-webrtc wrote:
> looks like we've regressed from the alphabetic order here, but if you could
fix
> it here so that Aec comes before Audio, that would be good.

Done.

https://codereview.webrtc.org/1866983002/diff/1/webrtc/api/statstypes.h
File webrtc/api/statstypes.h (right):

https://codereview.webrtc.org/1866983002/diff/1/webrtc/api/statstypes.h#newco...
webrtc/api/statstypes.h:112: kStatsValueNameAecDivergentFilterFraction,
On 2016/04/07 13:37:02, tommi-webrtc wrote:
> fix alphabetic sorting

Done.

[minyue-webrtc, 2016-04-07 14:47:58]

Description was changed from

==========
Add AEC filter divergence metric to StatsCollector.

A new metric that tells how often the AEC linear filter diverges has been
recently introduced, see 
https://codereview.webrtc.org/1739993003/

This metric can reflect echo failure and ducking.

In this CL, we add a field in StatsCollector to receive this metric.

BUG=
==========

to

==========
Add AEC filter divergence metric to StatsCollector.

A new metric that tells how often the AEC linear filter diverges has been
recently introduced, see
https://codereview.webrtc.org/1739993003/

This metric can reflect echo failure and ducking.

In this CL, we add a field in StatsCollector to receive this metric.

BUG=
R=tommi@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/2a8a78c905a68935d2ff53355...
==========

[commit-bot: I haz the power, 2016-04-07 14:47:59]

Description was changed from

==========
Add AEC filter divergence metric to StatsCollector.

A new metric that tells how often the AEC linear filter diverges has been
recently introduced, see
https://codereview.webrtc.org/1739993003/

This metric can reflect echo failure and ducking.

In this CL, we add a field in StatsCollector to receive this metric.

BUG=
R=tommi@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/2a8a78c905a68935d2ff53355...
==========

to

==========
Add AEC filter divergence metric to StatsCollector.

A new metric that tells how often the AEC linear filter diverges has been
recently introduced, see
https://codereview.webrtc.org/1739993003/

This metric can reflect echo failure and ducking.

In this CL, we add a field in StatsCollector to receive this metric.

BUG=
R=tommi@webrtc.org

Committed: https://crrev.com/2a8a78c905a68935d2ff53355982601e2e083dfa
Cr-Commit-Position: refs/heads/master@{#12282}
==========

[minyue-webrtc, 2016-04-07 14:48:00]

Committed patchset #2 (id:20001) manually as
2a8a78c905a68935d2ff53355982601e2e083dfa (presubmit successful).

[commit-bot: I haz the power, 2016-04-07 14:48:00]

Patchset 2 (id:??) landed as
https://crrev.com/2a8a78c905a68935d2ff53355982601e2e083dfa
Cr-Commit-Position: refs/heads/master@{#12282}