Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 1866653002: Revert of Switch to using EGL 1.0 for rendering and HW codec. (Closed)

Created:
4 years, 8 months ago by magjed_webrtc
Modified:
4 years, 8 months ago
Reviewers:
AlexG, jiayl2
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Switch to using EGL 1.0 for rendering and HW codec. (patchset #1 id:1 of https://codereview.webrtc.org/1829923002/ ) Reason for revert: EGL 1.4 was not the cause of the deadlock. See https://bugs.chromium.org/p/webrtc/issues/detail?id=5702 for more info. Original issue's description: > Switch to using EGL 1.0 for rendering and HW codec. > > Using EGL 1.4 may cause texture rendering deadlock on some > Android devices. > > R=jiayl@webrtc.org > > Committed: https://chromium.googlesource.com/external/webrtc/+/887a19b9d2be1ba90a407bd783be081087ffb0b1 BUG=webrtc:5702 TBR=jiayl@webrtc.org,glaznev@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. Committed: https://crrev.com/38d653c9272816e092fc241b51999a5595ab8aaf Cr-Commit-Position: refs/heads/master@{#12257}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -6 lines) Patch
M webrtc/api/java/android/org/webrtc/EglBase14.java View 1 chunk +3 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
magjed_webrtc
Created Revert of Switch to using EGL 1.0 for rendering and HW codec.
4 years, 8 months ago (2016-04-06 07:27:08 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1866653002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1866653002/1
4 years, 8 months ago (2016-04-06 07:28:06 UTC) #4
magjed_webrtc
4 years, 8 months ago (2016-04-06 07:29:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1866653002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1866653002/1
4 years, 8 months ago (2016-04-06 07:29:15 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-06 09:26:29 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-06 09:26:37 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/38d653c9272816e092fc241b51999a5595ab8aaf
Cr-Commit-Position: refs/heads/master@{#12257}

Powered by Google App Engine
This is Rietveld 408576698