🎺 Add isolate paths in GYP, fix location of test_runner.py in wrappers

Add isolate paths in GYP, fix location of test_runner.py in wrappers

BUG=599919
Committed: https://crrev.com/39530c489139b49f5c5b1df3e885a153f54571ba
Cr-Commit-Position: refs/heads/master@{#12283}

[agrieve, 2016-04-06 19:59:20]

Description was changed from

==========
Add isolate paths in GYP, fix location of test_runner.py in wrappers

BUG=599919
==========

to

==========
Add isolate paths in GYP, fix location of test_runner.py in wrappers

BUG=599919
==========

[agrieve, 2016-04-06 19:59:20]

agrieve@chromium.org changed reviewers:
+ kjellander@webrtc.org

[agrieve, 2016-04-06 19:59:51]

On 2016/04/06 19:59:20, agrieve wrote:
> mailto:agrieve@chromium.org changed reviewers:
> + mailto:kjellander@webrtc.org

[agrieve, 2016-04-06 20:38:27]

On 2016/04/06 19:59:51, agrieve wrote:
> On 2016/04/06 19:59:20, agrieve wrote:
> > mailto:agrieve@chromium.org changed reviewers:
> > + mailto:kjellander@webrtc.org

[kjellander_webrtc, 2016-04-07 07:52:52]

lgtm if you fix my suggestion.

I assume with this landed and when the bots have moved over to using the runner
scripts, we can remove the paths to .isolate files located in
https://chromium.googlesource.com/external/webrtc/+/master/webrtc/build/andro...
(assuming we also inform the devs about these changes)?

https://codereview.webrtc.org/1866123002/diff/1/webrtc/build/apk_tests.gyp
File webrtc/build/apk_tests.gyp (right):

https://codereview.webrtc.org/1866123002/diff/1/webrtc/build/apk_tests.gyp#ne...
webrtc/build/apk_tests.gyp:239: },
Can you add
'isolate_file': 'webrtc/modules/audio_codec_speed_tests.isolate',
here, even if that test is not actually run?

[agrieve, 2016-04-07 13:19:04]

https://codereview.webrtc.org/1866123002/diff/1/webrtc/build/apk_tests.gyp
File webrtc/build/apk_tests.gyp (right):

https://codereview.webrtc.org/1866123002/diff/1/webrtc/build/apk_tests.gyp#ne...
webrtc/build/apk_tests.gyp:239: },
On 2016/04/07 07:52:52, kjellander (webrtc) wrote:
> Can you add
> 'isolate_file': 'webrtc/modules/audio_codec_speed_tests.isolate',
> here, even if that test is not actually run?

Done.

[agrieve, 2016-04-07 13:20:55]

On 2016/04/07 13:19:04, agrieve wrote:
> https://codereview.webrtc.org/1866123002/diff/1/webrtc/build/apk_tests.gyp
> File webrtc/build/apk_tests.gyp (right):
> 
>
https://codereview.webrtc.org/1866123002/diff/1/webrtc/build/apk_tests.gyp#ne...
> webrtc/build/apk_tests.gyp:239: },
> On 2016/04/07 07:52:52, kjellander (webrtc) wrote:
> > Can you add
> > 'isolate_file': 'webrtc/modules/audio_codec_speed_tests.isolate',
> > here, even if that test is not actually run?
> 
> Done.

Yes, if bots & devs both move to using the wrappers, then the isolates in the
test_runner.py wrapper can be removed. The setting of the SRC_DIR I found was
still required though (so can't get rid of custom test_runner.py unless the
wrapper script writter was also updated to set that variable)

[agrieve, 2016-04-07 13:21:11]

The CQ bit was checked by agrieve@chromium.org

[agrieve, 2016-04-07 13:21:12]

The patchset sent to the CQ was uploaded after l-g-t-m from
kjellander@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1866123002/#ps20001 (title:
"add isolate for audio_codec_speed_tests_apk")

[commit-bot: I haz the power, 2016-04-07 13:21:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1866123002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1866123002/20001

[commit-bot: I haz the power, 2016-04-07 15:18:37]

Description was changed from

==========
Add isolate paths in GYP, fix location of test_runner.py in wrappers

BUG=599919
==========

to

==========
Add isolate paths in GYP, fix location of test_runner.py in wrappers

BUG=599919
==========

[commit-bot: I haz the power, 2016-04-07 15:18:38]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-07 15:18:48]

Description was changed from

==========
Add isolate paths in GYP, fix location of test_runner.py in wrappers

BUG=599919
==========

to

==========
Add isolate paths in GYP, fix location of test_runner.py in wrappers

BUG=599919

Committed: https://crrev.com/39530c489139b49f5c5b1df3e885a153f54571ba
Cr-Commit-Position: refs/heads/master@{#12283}
==========

[commit-bot: I haz the power, 2016-04-07 15:18:49]

Patchset 2 (id:??) landed as
https://crrev.com/39530c489139b49f5c5b1df3e885a153f54571ba
Cr-Commit-Position: refs/heads/master@{#12283}