Presubmit: Tweak the help text for making API changes

Presubmit: Tweak the help text for making API changes

While a three-month deprecation period is appropriate for some API
changes, it's too much for others. Change the help text to reflect
this.

Committed: https://crrev.com/eb13302e391fd67cf5ecd1b1018c02cf62ba0e4b
Cr-Commit-Position: refs/heads/master@{#12280}

[kwiberg-webrtc, 2016-04-07 12:27:00]

kwiberg@webrtc.org changed reviewers:
+ kjellander@webrtc.org, tommi@webrtc.org

[kwiberg-webrtc, 2016-04-07 12:27:01]

This is based on a face-to-face discussion between Tommi and me regarding the
schedule for replacing rtc::scoped_ptr with std::unique_ptr.

[kjellander_webrtc, 2016-04-07 12:44:03]

lgtm if you remove the strip()

https://codereview.webrtc.org/1865293002/diff/1/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.webrtc.org/1865293002/diff/1/PRESUBMIT.py#newcode113
PRESUBMIT.py:113: """.strip()
Remove the strip, as it will remove the last newline, which makes the output
look worse IMO.

[kwiberg-webrtc, 2016-04-07 12:52:24]

https://codereview.webrtc.org/1865293002/diff/1/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.webrtc.org/1865293002/diff/1/PRESUBMIT.py#newcode113
PRESUBMIT.py:113: """.strip()
On 2016/04/07 12:44:03, kjellander (webrtc) wrote:
> Remove the strip, as it will remove the last newline, which makes the output
> look worse IMO.

Gladly. I did it this way because that's what the old code did.

[tommi, 2016-04-07 12:52:56]

lgtm

[kwiberg-webrtc, 2016-04-07 12:53:30]

The CQ bit was checked by kwiberg@webrtc.org

[kwiberg-webrtc, 2016-04-07 12:53:30]

The patchset sent to the CQ was uploaded after l-g-t-m from
kjellander@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1865293002/#ps20001 (title:
"strip the strip")

[commit-bot: I haz the power, 2016-04-07 12:53:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1865293002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1865293002/20001

[kjellander_webrtc, 2016-04-07 13:04:13]

https://codereview.webrtc.org/1865293002/diff/1/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.webrtc.org/1865293002/diff/1/PRESUBMIT.py#newcode113
PRESUBMIT.py:113: """.strip()
On 2016/04/07 12:52:24, kwiberg-webrtc wrote:
> On 2016/04/07 12:44:03, kjellander (webrtc) wrote:
> > Remove the strip, as it will remove the last newline, which makes the output
> > look worse IMO.
> 
> Gladly. I did it this way because that's what the old code did.

Hmm, you're right the old code doesn't have a newline. Feel free to ignore my
comment then. I didn't try it myself so I guess the PresubmitNotifyResult
function possibly ends with a newline by itself before listing the files.

[kwiberg-webrtc, 2016-04-07 13:06:47]

https://codereview.webrtc.org/1865293002/diff/1/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.webrtc.org/1865293002/diff/1/PRESUBMIT.py#newcode113
PRESUBMIT.py:113: """.strip()
On 2016/04/07 13:04:13, kjellander (webrtc) wrote:
> On 2016/04/07 12:52:24, kwiberg-webrtc wrote:
> > On 2016/04/07 12:44:03, kjellander (webrtc) wrote:
> > > Remove the strip, as it will remove the last newline, which makes the
output
> > > look worse IMO.
> > 
> > Gladly. I did it this way because that's what the old code did.
> 
> Hmm, you're right the old code doesn't have a newline. Feel free to ignore my
> comment then. I didn't try it myself so I guess the PresubmitNotifyResult
> function possibly ends with a newline by itself before listing the files.

I tried both variants, and slightly prefer the non-stripping one. (Note that
without the strip, this CL adds a newline both before and after the text. This
makes it easier to read, IMO.)

[kjellander_webrtc, 2016-04-07 13:10:03]

FYI: no trybots needed for this CL (plz set NOTRY=True or just commit manually)

[commit-bot: I haz the power, 2016-04-07 14:41:53]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-07 14:41:59]

Description was changed from

==========
Presubmit: Tweak the help text for making API changes

While a three-month deprecation period is appropriate for some API
changes, it's too much for others. Change the help text to reflect
this.
==========

to

==========
Presubmit: Tweak the help text for making API changes

While a three-month deprecation period is appropriate for some API
changes, it's too much for others. Change the help text to reflect
this.

Committed: https://crrev.com/eb13302e391fd67cf5ecd1b1018c02cf62ba0e4b
Cr-Commit-Position: refs/heads/master@{#12280}
==========

[commit-bot: I haz the power, 2016-04-07 14:42:00]

Patchset 2 (id:??) landed as
https://crrev.com/eb13302e391fd67cf5ecd1b1018c02cf62ba0e4b
Cr-Commit-Position: refs/heads/master@{#12280}