Use microsecond timestamp in cricket::VideoFrame.

webrtc/media/engine/webrtcvideoframe_unittest.cc

 /*
  *  Copyright (c) 2011 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
 #include <string.h>
 
 #include <memory>
 
 #include "webrtc/media/base/videoframe_unittest.h"
 #include "webrtc/media/engine/webrtcvideoframe.h"
 #include "webrtc/test/fake_texture_frame.h"
 
 namespace {
 
 class WebRtcVideoTestFrame : public cricket::WebRtcVideoFrame {
  public:
   using cricket::WebRtcVideoFrame::set_rotation;

[pbos-webrtc, 2016/04/13 13:42:09]

Is this using required?

[nisse-webrtc, 2016/04/13 14:37:33]

Yes. It's a protected method in the base class, and the ApplyRotationToFrame
testcase needs it to be public.

On the other hand, the strange CreateEmptyFrame just below appear unused.

 
   virtual VideoFrame* CreateEmptyFrame(int w,
                                        int h,
                                        int64_t time_stamp) const override {
     WebRtcVideoTestFrame* frame = new WebRtcVideoTestFrame();
     frame->InitToBlack(w, h, time_stamp);
     return frame;
   }
 };
 
 }  // namespace
 
 class WebRtcVideoFrameTest : public VideoFrameTest<cricket::WebRtcVideoFrame> {
  public:
   WebRtcVideoFrameTest() {
   }
 
   void TestInit(int cropped_width, int cropped_height,
                 webrtc::VideoRotation frame_rotation,
                 bool apply_rotation) {
     const int frame_width = 1920;
     const int frame_height = 1080;
 
     // Build the CapturedFrame.
     cricket::CapturedFrame captured_frame;
     captured_frame.fourcc = cricket::FOURCC_I420;
-    captured_frame.time_stamp = 5678;
+    captured_frame.time_stamp = rtc::TimeNanos();
     captured_frame.rotation = frame_rotation;
     captured_frame.width = frame_width;
     captured_frame.height = frame_height;
     captured_frame.data_size = (frame_width * frame_height) +
         ((frame_width + 1) / 2) * ((frame_height + 1) / 2) * 2;
     std::unique_ptr<uint8_t[]> captured_frame_buffer(
         new uint8_t[captured_frame.data_size]);
     // Initialize memory to satisfy DrMemory tests.
     memset(captured_frame_buffer.get(), 0, captured_frame.data_size);
     captured_frame.data = captured_frame_buffer.get();
 
     // Create the new frame from the CapturedFrame.
     cricket::WebRtcVideoFrame frame;
     EXPECT_TRUE(
         frame.Init(&captured_frame, cropped_width, cropped_height,
                    apply_rotation));
 
     // Verify the new frame.
-    EXPECT_EQ(5678, frame.GetTimeStamp());
+    EXPECT_EQ(captured_frame.time_stamp / rtc::kNumNanosecsPerMicrosec,
+              frame.timestamp_us());
     if (apply_rotation)
       EXPECT_EQ(webrtc::kVideoRotation_0, frame.rotation());
     else
       EXPECT_EQ(frame_rotation, frame.rotation());
     // If |apply_rotation| and the frame rotation is 90 or 270, width and
     // height are flipped.
     if (apply_rotation && (frame_rotation == webrtc::kVideoRotation_90
         || frame_rotation == webrtc::kVideoRotation_270)) {
       EXPECT_EQ(cropped_width, frame.height());
       EXPECT_EQ(cropped_height, frame.width());
@@ skipping 184 matching lines @@
 TEST_F(WebRtcVideoFrameTest, InitRotated90DontApplyRotation) {
   TestInit(640, 360, webrtc::kVideoRotation_90, false);
 }
 
 TEST_F(WebRtcVideoFrameTest, TextureInitialValues) {
   webrtc::test::FakeNativeHandle* dummy_handle =
       new webrtc::test::FakeNativeHandle();
   webrtc::NativeHandleBuffer* buffer =
       new rtc::RefCountedObject<webrtc::test::FakeNativeHandleBuffer>(
           dummy_handle, 640, 480);
-  cricket::WebRtcVideoFrame frame(buffer, 200, webrtc::kVideoRotation_0);
+  // Timestamp is converted from ns to us, so last three digits are lost.
+  cricket::WebRtcVideoFrame frame(buffer, 20000, webrtc::kVideoRotation_0);
   EXPECT_EQ(dummy_handle, frame.GetNativeHandle());
   EXPECT_EQ(640, frame.width());
   EXPECT_EQ(480, frame.height());
-  EXPECT_EQ(200, frame.GetTimeStamp());
-  frame.SetTimeStamp(400);
-  EXPECT_EQ(400, frame.GetTimeStamp());
+  EXPECT_EQ(20000, frame.GetTimeStamp());
+  EXPECT_EQ(20, frame.timestamp_us());
+  frame.set_timestamp_us(40);
+  EXPECT_EQ(40000, frame.GetTimeStamp());
+  EXPECT_EQ(40, frame.timestamp_us());
 }
 
 TEST_F(WebRtcVideoFrameTest, CopyTextureFrame) {
   webrtc::test::FakeNativeHandle* dummy_handle =
       new webrtc::test::FakeNativeHandle();
   webrtc::NativeHandleBuffer* buffer =
       new rtc::RefCountedObject<webrtc::test::FakeNativeHandleBuffer>(
           dummy_handle, 640, 480);
-  cricket::WebRtcVideoFrame frame1(buffer, 200, webrtc::kVideoRotation_0);
+  // Timestamp is converted from ns to us, so last three digits are lost.
+  cricket::WebRtcVideoFrame frame1(buffer, 20000, webrtc::kVideoRotation_0);
   cricket::VideoFrame* frame2 = frame1.Copy();
   EXPECT_EQ(frame1.GetNativeHandle(), frame2->GetNativeHandle());
   EXPECT_EQ(frame1.width(), frame2->width());
   EXPECT_EQ(frame1.height(), frame2->height());
   EXPECT_EQ(frame1.GetTimeStamp(), frame2->GetTimeStamp());
+  EXPECT_EQ(frame1.timestamp_us(), frame2->timestamp_us());
   delete frame2;
 }
 
 TEST_F(WebRtcVideoFrameTest, ApplyRotationToFrame) {
   WebRtcVideoTestFrame applied0;
   EXPECT_TRUE(IsNull(applied0));
   std::unique_ptr<rtc::MemoryStream> ms(CreateYuvSample(kWidth, kHeight, 12));
   EXPECT_TRUE(
       LoadFrame(ms.get(), cricket::FOURCC_I420, kWidth, kHeight, &applied0));
 
@@ skipping 10 matching lines @@
 
   // Claim the frame 2 needs to be rotated for another 270 degree. The output
   // from frame 2 rotation should be the same as frame 1.
   applied90->set_rotation(webrtc::kVideoRotation_270);
   const cricket::VideoFrame* applied360 =
       applied90->GetCopyWithRotationApplied();
   EXPECT_TRUE(applied360);
   EXPECT_EQ(applied360->rotation(), webrtc::kVideoRotation_0);
   EXPECT_TRUE(IsEqual(applied0, *applied360, 0));
 }