Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 1864453002: Fixing an error in DebugDumpTest. (Closed)

Created:
4 years, 8 months ago by minyue-webrtc
Modified:
4 years, 8 months ago
Reviewers:
hlundin-webrtc
CC:
webrtc-reviews_webrtc.org, peah-webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fixing an error in DebugDumpTest. A recent change in DebugDumpTest introduced an error https://codereview.webrtc.org/1810463002/ The file was not fully scanned. This CL fixes it. BUG= Committed: https://crrev.com/9705bb81d67fa7a04bb0f6ee8f537aeb9759e0be Cr-Commit-Position: refs/heads/master@{#12236}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M webrtc/modules/audio_processing/test/debug_dump_test.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
minyue-webrtc
Hi Henrik, Here is a tiny CL. Would you help review?
4 years, 8 months ago (2016-04-05 09:06:16 UTC) #3
hlundin-webrtc
lgtm
4 years, 8 months ago (2016-04-05 09:16:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1864453002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1864453002/1
4 years, 8 months ago (2016-04-05 09:51:01 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-05 11:39:20 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-05 11:39:26 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9705bb81d67fa7a04bb0f6ee8f537aeb9759e0be
Cr-Commit-Position: refs/heads/master@{#12236}

Powered by Google App Engine
This is Rietveld 408576698