Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Unified Diff: webrtc/video/vie_receiver.h

Issue 1864313003: Move Ownership of RtpModules to VideoSendStream. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Addressed comments Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/video/vie_receiver.h
diff --git a/webrtc/video/vie_receiver.h b/webrtc/video/vie_receiver.h
index 999e66d68b1e0006610df87e852fa407cc7227d6..c96bf5e107328ac6e8798ed03297d25d628dd61e 100644
--- a/webrtc/video/vie_receiver.h
+++ b/webrtc/video/vie_receiver.h
@@ -60,7 +60,7 @@ class ViEReceiver : public RtpData {
uint32_t GetRemoteSsrc() const;
int GetCsrcs(uint32_t* csrcs) const;
- void Init(const std::vector<RtpRtcp*>& modules);
+ void Init(RtpRtcp* rtp_rtcp);
RtpReceiver* GetRtpReceiver() const;
@@ -102,7 +102,7 @@ class ViEReceiver : public RtpData {
RemoteBitrateEstimator* const remote_bitrate_estimator_;
// TODO(pbos): Make const and set on construction.
- std::vector<RtpRtcp*> rtp_rtcp_;
+ RtpRtcp* rtp_rtcp_; // Owned by ViEChannel
mflodman 2016/04/15 08:25:42 Maybe resolve pbos' todo when at this, should be e
perkj_webrtc 2016/04/15 08:36:42 Its not that easy since there is a circular depend
RemoteNtpTimeEstimator ntp_estimator_;
RTPPayloadRegistry rtp_payload_registry_;

Powered by Google App Engine
This is Rietveld 408576698