Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1364)

Unified Diff: webrtc/modules/audio_coding/acm2/acm_receiver.cc

Issue 1863993002: Move setting of AudioFrame::timestamp_ into NetEq (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@neteq-empty-playout-ts
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/audio_coding/acm2/acm_receiver.cc
diff --git a/webrtc/modules/audio_coding/acm2/acm_receiver.cc b/webrtc/modules/audio_coding/acm2/acm_receiver.cc
index 925e99c5d6381868f0bca60f36cf6af4e04ad705..f8bacf8dc7d4a97ad4d267bb23d6a9f7bab35c2b 100644
--- a/webrtc/modules/audio_coding/acm2/acm_receiver.cc
+++ b/webrtc/modules/audio_coding/acm2/acm_receiver.cc
@@ -191,21 +191,6 @@ int AcmReceiver::GetAudio(int desired_freq_hz, AudioFrame* audio_frame) {
audio_frame->num_channels_);
call_stats_.DecodedByNetEq(audio_frame->speech_type_);
-
- // Computes the RTP timestamp of the first sample in |audio_frame| from
- // |GetPlayoutTimestamp|, which is the timestamp of the last sample of
- // |audio_frame|.
- // TODO(henrik.lundin) Move setting of audio_frame->timestamp_ inside NetEq.
- rtc::Optional<uint32_t> playout_timestamp = GetPlayoutTimestamp();
- if (playout_timestamp) {
- audio_frame->timestamp_ =
- *playout_timestamp -
- static_cast<uint32_t>(audio_frame->samples_per_channel_);
- } else {
- // Remain 0 until we have a valid |playout_timestamp|.
- audio_frame->timestamp_ = 0;
- }
-
return 0;
}

Powered by Google App Engine
This is Rietveld 408576698