Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 1863993002: Move setting of AudioFrame::timestamp_ into NetEq (Closed)

Created:
4 years, 8 months ago by hlundin-webrtc
Modified:
4 years, 8 months ago
Reviewers:
minyue-webrtc
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@neteq-empty-playout-ts
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Move setting of AudioFrame::timestamp_ into NetEq This was previously done in AcmReceiver, but belongs in NetEq where the rest of the AudioFrame fields are populated. BUG=webrtc:5669, webrtc:5607 Committed: https://crrev.com/15c51e355f9ade7fbeb7f7ac6784c0f24446ab7e Cr-Commit-Position: refs/heads/master@{#12265}

Patch Set 1 : #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -18 lines) Patch
M webrtc/modules/audio_coding/acm2/acm_receiver.cc View 1 chunk +0 lines, -15 lines 0 comments Download
M webrtc/modules/audio_coding/acm2/acm_receiver_unittest_oldapi.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/include/neteq.h View 1 chunk +1 line, -1 line 1 comment Download
M webrtc/modules/audio_coding/neteq/neteq_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq_impl.cc View 2 chunks +10 lines, -1 line 2 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (6 generated)
hlundin-webrtc
https://codereview.webrtc.org/1863993002/diff/20001/webrtc/modules/audio_coding/neteq/include/neteq.h File webrtc/modules/audio_coding/neteq/include/neteq.h (right): https://codereview.webrtc.org/1863993002/diff/20001/webrtc/modules/audio_coding/neteq/include/neteq.h#newcode249 webrtc/modules/audio_coding/neteq/include/neteq.h:249: virtual rtc::Optional<uint32_t> GetPlayoutTimestamp() const = 0; This was always ...
4 years, 8 months ago (2016-04-06 09:34:07 UTC) #3
minyue-webrtc
lgtm https://codereview.webrtc.org/1863993002/diff/20001/webrtc/modules/audio_coding/neteq/neteq_impl.cc File webrtc/modules/audio_coding/neteq/neteq_impl.cc (right): https://codereview.webrtc.org/1863993002/diff/20001/webrtc/modules/audio_coding/neteq/neteq_impl.cc#newcode973 webrtc/modules/audio_coding/neteq/neteq_impl.cc:973: audio_frame->timestamp_ = maybe too many lines here
4 years, 8 months ago (2016-04-06 11:16:26 UTC) #4
hlundin-webrtc
Thanks! https://codereview.webrtc.org/1863993002/diff/20001/webrtc/modules/audio_coding/neteq/neteq_impl.cc File webrtc/modules/audio_coding/neteq/neteq_impl.cc (right): https://codereview.webrtc.org/1863993002/diff/20001/webrtc/modules/audio_coding/neteq/neteq_impl.cc#newcode973 webrtc/modules/audio_coding/neteq/neteq_impl.cc:973: audio_frame->timestamp_ = On 2016/04/06 11:16:26, minyue-webrtc wrote: > ...
4 years, 8 months ago (2016-04-06 11:18:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1863993002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1863993002/20001
4 years, 8 months ago (2016-04-06 11:20:13 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL) win_baremetal on ...
4 years, 8 months ago (2016-04-06 13:20:51 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1863993002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1863993002/20001
4 years, 8 months ago (2016-04-06 15:33:41 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 8 months ago (2016-04-06 15:39:01 UTC) #12
commit-bot: I haz the power
4 years, 8 months ago (2016-04-06 15:39:06 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/15c51e355f9ade7fbeb7f7ac6784c0f24446ab7e
Cr-Commit-Position: refs/heads/master@{#12265}

Powered by Google App Engine
This is Rietveld 408576698