Gracefully continue if ConnectivityManager.requestNetwork fails.

Gracefully continue if ConnectivityManager.requestNetwork fails.

This happens on Android 6.0.0, which requires the WRITE_SETTINGS
permission, which is somewhat impractical to obtain.

R=glaznev@webrtc.org

Committed: https://crrev.com/05697a62fce79c95e483a6b7e4fd4fb99033e567
Cr-Commit-Position: refs/heads/master@{#12288}

[Taylor Brandstetter, 2016-04-07 18:39:04]

deadbeef@webrtc.org changed reviewers:
+ glaznev@webrtc.org

[Taylor Brandstetter, 2016-04-07 18:39:05]

PTAL.

https://codereview.webrtc.org/1863413003/diff/20001/webrtc/api/java/android/o...
File webrtc/api/java/android/org/webrtc/NetworkMonitorAutoDetect.java (right):

https://codereview.webrtc.org/1863413003/diff/20001/webrtc/api/java/android/o...
webrtc/api/java/android/org/webrtc/NetworkMonitorAutoDetect.java:450:
NetworkCallback tempNetworkCallback = new NetworkCallback();
I'm using `tempNetworkCallback` here since `mobileNetworkCallback` is final.

[AlexG, 2016-04-07 20:17:18]

https://codereview.webrtc.org/1863413003/diff/20001/webrtc/api/java/android/o...
File webrtc/api/java/android/org/webrtc/NetworkMonitorAutoDetect.java (right):

https://codereview.webrtc.org/1863413003/diff/20001/webrtc/api/java/android/o...
webrtc/api/java/android/org/webrtc/NetworkMonitorAutoDetect.java:450:
NetworkCallback tempNetworkCallback = new NetworkCallback();
On 2016/04/07 18:39:04, Taylor Brandstetter wrote:
> I'm using `tempNetworkCallback` here since `mobileNetworkCallback` is final.

Remove final modifier?

https://codereview.webrtc.org/1863413003/diff/20001/webrtc/api/java/android/o...
webrtc/api/java/android/org/webrtc/NetworkMonitorAutoDetect.java:452:
connectivityManagerDelegate.requestMobileNetwork(mobileNetworkCallback);
tempNetworkCallback should be used here?

[AlexG, 2016-04-07 20:29:03]

https://codereview.webrtc.org/1863413003/diff/20001/webrtc/api/java/android/o...
File webrtc/api/java/android/org/webrtc/NetworkMonitorAutoDetect.java (right):

https://codereview.webrtc.org/1863413003/diff/20001/webrtc/api/java/android/o...
webrtc/api/java/android/org/webrtc/NetworkMonitorAutoDetect.java:450:
NetworkCallback tempNetworkCallback = new NetworkCallback();
On 2016/04/07 20:17:18, AlexG wrote:
> On 2016/04/07 18:39:04, Taylor Brandstetter wrote:
> > I'm using `tempNetworkCallback` here since `mobileNetworkCallback` is final.
> 
> Remove final modifier?

Sorry, probably a bad idea - all other fields are final.

[Taylor Brandstetter, 2016-04-07 23:03:09]

https://codereview.webrtc.org/1863413003/diff/20001/webrtc/api/java/android/o...
File webrtc/api/java/android/org/webrtc/NetworkMonitorAutoDetect.java (right):

https://codereview.webrtc.org/1863413003/diff/20001/webrtc/api/java/android/o...
webrtc/api/java/android/org/webrtc/NetworkMonitorAutoDetect.java:452:
connectivityManagerDelegate.requestMobileNetwork(mobileNetworkCallback);
On 2016/04/07 20:17:17, AlexG wrote:
> tempNetworkCallback should be used here?

Done.

[AlexG, 2016-04-07 23:04:16]

lgtm

[Taylor Brandstetter, 2016-04-08 00:36:59]

Description was changed from

==========
Gracefully continue if ConnectivityManager.requestNetwork fails.

This happens on Android 6.0.0, which requires the WRITE_SETTINGS
permission, which is somewhat impractical to obtain.
==========

to

==========
Gracefully continue if ConnectivityManager.requestNetwork fails.

This happens on Android 6.0.0, which requires the WRITE_SETTINGS
permission, which is somewhat impractical to obtain.

R=glaznev@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/05697a62fce79c95e483a6b7e...
==========

[commit-bot: I haz the power, 2016-04-08 00:36:59]

Description was changed from

==========
Gracefully continue if ConnectivityManager.requestNetwork fails.

This happens on Android 6.0.0, which requires the WRITE_SETTINGS
permission, which is somewhat impractical to obtain.

R=glaznev@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/05697a62fce79c95e483a6b7e...
==========

to

==========
Gracefully continue if ConnectivityManager.requestNetwork fails.

This happens on Android 6.0.0, which requires the WRITE_SETTINGS
permission, which is somewhat impractical to obtain.

R=glaznev@webrtc.org

Committed: https://crrev.com/05697a62fce79c95e483a6b7e4fd4fb99033e567
Cr-Commit-Position: refs/heads/master@{#12288}
==========

[Taylor Brandstetter, 2016-04-08 00:37:00]

Committed patchset #3 (id:30002) manually as
05697a62fce79c95e483a6b7e4fd4fb99033e567 (presubmit successful).

[commit-bot: I haz the power, 2016-04-08 00:37:00]

Patchset 3 (id:??) landed as
https://crrev.com/05697a62fce79c95e483a6b7e4fd4fb99033e567
Cr-Commit-Position: refs/heads/master@{#12288}