Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 1863023002: Gave the ClosestNativeRate method in APM a more proper name (Closed)

Created:
4 years, 8 months ago by peah-webrtc
Modified:
4 years, 8 months ago
Reviewers:
the sun, aluebs-webrtc
CC:
webrtc-reviews_webrtc.org, peah-webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

As the ClosestNativeRate method returns the closest native rate that is higher than the specified rate, and not the closest native rate the need for a name change has been raised. This CL addresses that. BUG=webrtc:5298 Committed: https://crrev.com/423d236a5421c58e3f2cf4dee014860187f822d8 Cr-Commit-Position: refs/heads/master@{#12302}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Added external declaration to the delay estimator wrapper #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M webrtc/modules/audio_processing/audio_processing_impl.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
peah-webrtc
4 years, 8 months ago (2016-04-06 09:53:35 UTC) #3
the sun
lgtm
4 years, 8 months ago (2016-04-06 11:59:21 UTC) #5
aluebs-webrtc
lgtm
4 years, 8 months ago (2016-04-06 17:23:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1863023002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1863023002/1
4 years, 8 months ago (2016-04-08 21:31:14 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios_dbg/builds/14075) mac_baremetal on tryserver.webrtc (JOB_FAILED, ...
4 years, 8 months ago (2016-04-08 21:32:08 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1863023002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1863023002/20001
4 years, 8 months ago (2016-04-09 21:09:52 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-09 23:06:57 UTC) #15
commit-bot: I haz the power
4 years, 8 months ago (2016-04-09 23:07:11 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/423d236a5421c58e3f2cf4dee014860187f822d8
Cr-Commit-Position: refs/heads/master@{#12302}

Powered by Google App Engine
This is Rietveld 408576698