Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(597)

Side by Side Diff: webrtc/modules/audio_processing/test/audio_processing_unittest.cc

Issue 1862933002: Increase kHasVoiceCountNear by one in audio_processing_unittest (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 2156 matching lines...) Expand 10 before | Expand all | Expand 10 after
2167 if (!write_ref_data) { 2167 if (!write_ref_data) {
2168 const int kIntNear = 1; 2168 const int kIntNear = 1;
2169 // When running the test on a N7 we get a {2, 6} difference of 2169 // When running the test on a N7 we get a {2, 6} difference of
2170 // |has_voice_count| and |max_output_average| is up to 18 higher. 2170 // |has_voice_count| and |max_output_average| is up to 18 higher.
2171 // All numbers being consistently higher on N7 compare to ref_data. 2171 // All numbers being consistently higher on N7 compare to ref_data.
2172 // TODO(bjornv): If we start getting more of these offsets on Android we 2172 // TODO(bjornv): If we start getting more of these offsets on Android we
2173 // should consider a different approach. Either using one slack for all, 2173 // should consider a different approach. Either using one slack for all,
2174 // or generate a separate android reference. 2174 // or generate a separate android reference.
2175 #if defined(WEBRTC_ANDROID) 2175 #if defined(WEBRTC_ANDROID)
2176 const int kHasVoiceCountOffset = 3; 2176 const int kHasVoiceCountOffset = 3;
2177 const int kHasVoiceCountNear = 3; 2177 const int kHasVoiceCountNear = 4;
2178 const int kMaxOutputAverageOffset = 9; 2178 const int kMaxOutputAverageOffset = 9;
2179 const int kMaxOutputAverageNear = 9; 2179 const int kMaxOutputAverageNear = 9;
2180 #else 2180 #else
2181 const int kHasVoiceCountOffset = 0; 2181 const int kHasVoiceCountOffset = 0;
2182 const int kHasVoiceCountNear = kIntNear; 2182 const int kHasVoiceCountNear = kIntNear;
2183 const int kMaxOutputAverageOffset = 0; 2183 const int kMaxOutputAverageOffset = 0;
2184 const int kMaxOutputAverageNear = kIntNear; 2184 const int kMaxOutputAverageNear = kIntNear;
2185 #endif 2185 #endif
2186 EXPECT_NEAR(test->has_echo_count(), has_echo_count, kIntNear); 2186 EXPECT_NEAR(test->has_echo_count(), has_echo_count, kIntNear);
2187 EXPECT_NEAR(test->has_voice_count(), 2187 EXPECT_NEAR(test->has_voice_count(),
(...skipping 559 matching lines...) Expand 10 before | Expand all | Expand 10 after
2747 std::tr1::make_tuple(16000, 32000, 48000, 32000, 25, 35), 2747 std::tr1::make_tuple(16000, 32000, 48000, 32000, 25, 35),
2748 std::tr1::make_tuple(16000, 32000, 32000, 32000, 25, 0), 2748 std::tr1::make_tuple(16000, 32000, 32000, 32000, 25, 0),
2749 std::tr1::make_tuple(16000, 32000, 16000, 32000, 25, 20), 2749 std::tr1::make_tuple(16000, 32000, 16000, 32000, 25, 20),
2750 std::tr1::make_tuple(16000, 16000, 48000, 16000, 35, 20), 2750 std::tr1::make_tuple(16000, 16000, 48000, 16000, 35, 20),
2751 std::tr1::make_tuple(16000, 16000, 32000, 16000, 35, 20), 2751 std::tr1::make_tuple(16000, 16000, 32000, 16000, 35, 20),
2752 std::tr1::make_tuple(16000, 16000, 16000, 16000, 0, 0))); 2752 std::tr1::make_tuple(16000, 16000, 16000, 16000, 0, 0)));
2753 #endif 2753 #endif
2754 2754
2755 } // namespace 2755 } // namespace
2756 } // namespace webrtc 2756 } // namespace webrtc
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698