Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 1862513007: Moved struct definition to the header file for the ring buffer. (Closed)

Created:
4 years, 8 months ago by peah-webrtc
Modified:
4 years, 8 months ago
Reviewers:
ivoc, kwiberg-webrtc
CC:
webrtc-reviews_webrtc.org, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, peah-webrtc, minyue-webrtc, aluebs-webrtc, bjornv1
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Moved struct definition to the header file for the ring buffer. This is done in order to allow the ringbuffer to be recorded using protobufs. The actual recording will be added in other CLs. BUG=webrtc:5724 Committed: https://crrev.com/4d23447b1548fa31e54f92754661af0740008b3d Cr-Commit-Position: refs/heads/master@{#12308}

Patch Set 1 : #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -15 lines) Patch
M webrtc/common_audio/ring_buffer.h View 1 chunk +10 lines, -1 line 0 comments Download
M webrtc/common_audio/ring_buffer.c View 1 chunk +0 lines, -14 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
peah-webrtc
4 years, 8 months ago (2016-04-06 12:13:58 UTC) #3
ivoc
LGTM :)
4 years, 8 months ago (2016-04-06 12:15:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1862513007/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1862513007/20001
4 years, 8 months ago (2016-04-08 21:31:34 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/4692)
4 years, 8 months ago (2016-04-08 21:41:28 UTC) #8
peah-webrtc
+kwiberg as being an OWNER of the ring_buffer
4 years, 8 months ago (2016-04-09 21:04:51 UTC) #10
kwiberg-webrtc
lgtm I don't really like exposing the internals of a data structure like this, but ...
4 years, 8 months ago (2016-04-09 22:36:34 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1862513007/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1862513007/40001
4 years, 8 months ago (2016-04-11 04:42:21 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 8 months ago (2016-04-11 05:51:12 UTC) #15
commit-bot: I haz the power
4 years, 8 months ago (2016-04-11 05:51:19 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4d23447b1548fa31e54f92754661af0740008b3d
Cr-Commit-Position: refs/heads/master@{#12308}

Powered by Google App Engine
This is Rietveld 408576698