Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1862423002: Update ice server provider response format in the Android AppRTCDemo app (Closed)

Created:
4 years, 8 months ago by janssonWebRTC
Modified:
4 years, 8 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Update ice server provider response format in the Android AppRTCDemo app BUG=None Committed: https://crrev.com/18d3d1e466518acf8bf06b9ef935c5cb7a67f750 Cr-Commit-Position: refs/heads/master@{#12310}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -8 lines) Patch
M webrtc/examples/androidapp/src/org/appspot/apprtc/RoomParametersFetcher.java View 3 chunks +18 lines, -8 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
janssonWebRTC
andresp@ PTAL at this CL. Adding Alex and Zeke due to OWNERS.
4 years, 8 months ago (2016-04-07 14:13:58 UTC) #2
AlexG
lgtm
4 years, 8 months ago (2016-04-07 17:47:01 UTC) #3
andresp
On 2016/04/07 17:47:01, AlexG wrote: > lgtm lgtm
4 years, 8 months ago (2016-04-11 08:17:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1862423002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1862423002/1
4 years, 8 months ago (2016-04-11 08:44:50 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_clang_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_clang_dbg/builds/2384)
4 years, 8 months ago (2016-04-11 08:55:40 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1862423002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1862423002/1
4 years, 8 months ago (2016-04-11 09:05:12 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-11 09:42:18 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-11 09:42:25 UTC) #13
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/18d3d1e466518acf8bf06b9ef935c5cb7a67f750
Cr-Commit-Position: refs/heads/master@{#12310}

Powered by Google App Engine
This is Rietveld 408576698