Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Unified Diff: webrtc/api/videosourceproxy.h

Issue 1861633002: Extended proxy abstraction, to call certain methods to the worker thread. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Minor formatting tweak. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/api/videosourceproxy.h
diff --git a/webrtc/api/videosourceproxy.h b/webrtc/api/videosourceproxy.h
index f43c0db69f2b6a69d1f8cc7591f13bafe16728ee..985bc520868f64bd7d1ac03e01b3c46928f4b62b 100644
--- a/webrtc/api/videosourceproxy.h
+++ b/webrtc/api/videosourceproxy.h
@@ -20,7 +20,7 @@ namespace webrtc {
// implementation is
// destroyed on the signaling thread and marshals all method calls to the
// signaling thread.
-BEGIN_PROXY_MAP(VideoTrackSource)
+BEGIN_WORKER_PROXY_MAP(VideoTrackSource)
PROXY_CONSTMETHOD0(SourceState, state)
tommi 2016/04/07 11:50:03 nit: can you indent this as is done in the other f
nisse-webrtc 2016/04/07 12:51:29 Sure. (git cl format would prefer the opposite cha
PROXY_CONSTMETHOD0(bool, remote)
PROXY_METHOD0(cricket::VideoCapturer*, GetVideoCapturer)
@@ -29,14 +29,16 @@ PROXY_METHOD0(void, Restart)
PROXY_CONSTMETHOD0(bool, is_screencast)
PROXY_CONSTMETHOD0(rtc::Optional<bool>, needs_denoising)
PROXY_METHOD1(bool, GetStats, Stats*)
-PROXY_METHOD2(void,
- AddOrUpdateSink,
- rtc::VideoSinkInterface<cricket::VideoFrame>*,
- const rtc::VideoSinkWants&)
-PROXY_METHOD1(void, RemoveSink, rtc::VideoSinkInterface<cricket::VideoFrame>*)
+PROXY_WORKER_METHOD2(void,
+ AddOrUpdateSink,
+ rtc::VideoSinkInterface<cricket::VideoFrame>*,
+ const rtc::VideoSinkWants&)
+PROXY_WORKER_METHOD1(void,
+ RemoveSink,
+ rtc::VideoSinkInterface<cricket::VideoFrame>*)
PROXY_METHOD1(void, RegisterObserver, ObserverInterface*)
PROXY_METHOD1(void, UnregisterObserver, ObserverInterface*)
-END_PROXY()
+END_WORKER_PROXY()
} // namespace webrtc

Powered by Google App Engine
This is Rietveld 408576698