Extended proxy abstraction, to call certain methods to the worker thread.

webrtc/api/proxy.h

 /*
  *  Copyright 2013 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 278 matching lines @@
   Method m_;
   ReturnType<R> r_;
   T1 a1_;
   T2 a2_;
   T3 a3_;
   T4 a4_;
   T5 a5_;
 };
 
 #define BEGIN_PROXY_MAP(c)                                                \
   class c##Proxy : public c##Interface {                                  \

[tommi, 2016/04/07 11:50:03]

nit: Could change this to:
class c##SignalingProxy : public c##Interface { 

The only thing it does is make the symbols a bit clearer, but that can be useful
sometimes.

[nisse-webrtc, 2016/04/07 12:51:29]

It changes the name of the constructor. I think I'd prefer to postpone that to
renaming, to limit changes to code using the unchanged variant of the proxy.

    protected:                                                             \
     typedef c##Interface C;                                               \
-    c##Proxy(rtc::Thread* thread, C* c) : owner_thread_(thread), c_(c) {} \
+    c##Proxy(rtc::Thread* signaling_thread, C* c)                         \
+      : signaling_thread_(signaling_thread), c_(c) {}                     \
     ~c##Proxy() {                                                         \
       MethodCall0<c##Proxy, void> call(this, &c##Proxy::Release_s);       \
-      call.Marshal(owner_thread_);                                        \
+      call.Marshal(signaling_thread_);                                    \
     }                                                                     \
                                                                           \
    public:                                                                \
-    static rtc::scoped_refptr<C> Create(rtc::Thread* thread, C* c) {      \
-      return new rtc::RefCountedObject<c##Proxy>(thread, c);              \
+    static rtc::scoped_refptr<C> Create(rtc::Thread* signaling_thread, C* c) { \
+      return new rtc::RefCountedObject<c##Proxy>(signaling_thread, c);    \
+    }
+
+#define BEGIN_WORKER_PROXY_MAP(c)                                       \
+  class c##Proxy : public c##Interface {                                \
+   protected:                                                           \
+    typedef c##Interface C;                                             \
+    c##Proxy(rtc::Thread* signaling_thread, rtc::Thread* worker_thread, C* c) \
+      : signaling_thread_(signaling_thread),                            \

[tommi, 2016/04/07 11:50:03]

indent looks off... does "git cl format" ignore this since it's a macro?

[nisse-webrtc, 2016/04/07 12:51:29]

git cl format wants to change indentation in this file completely. I didn't do
that, to avoid changes to the parts I haven't touch. Could do a reformat in a
the same followup as the renaming.

+        worker_thread_(worker_thread),                                  \
+        c_(c) {}                                                        \
+    ~c##Proxy() {                                                       \
+      MethodCall0<c##Proxy, void> call(this, &c##Proxy::Release_s);     \
+      call.Marshal(signaling_thread_);                                  \
+    }                                                                   \
+                                                                        \
+   public:                                                              \
+    static rtc::scoped_refptr<C> Create(                                \
+        rtc::Thread* signaling_thread, rtc::Thread* worker_thread, C* c) { \
+      return new rtc::RefCountedObject<c##Proxy>(                       \
+          signaling_thread, worker_thread, c);                          \
     }
 
 #define PROXY_METHOD0(r, method)                  \
   r method() override {                           \
     MethodCall0<C, r> call(c_.get(), &C::method); \
-    return call.Marshal(owner_thread_);           \
+    return call.Marshal(signaling_thread_);       \
   }
 
 #define PROXY_CONSTMETHOD0(r, method)                  \
   r method() const override {                          \
     ConstMethodCall0<C, r> call(c_.get(), &C::method); \
-    return call.Marshal(owner_thread_);                \
+    return call.Marshal(signaling_thread_);            \
   }
 
 #define PROXY_METHOD1(r, method, t1)                      \
   r method(t1 a1) override {                              \
     MethodCall1<C, r, t1> call(c_.get(), &C::method, a1); \
-    return call.Marshal(owner_thread_);                   \
+    return call.Marshal(signaling_thread_);               \
   }
 
 #define PROXY_CONSTMETHOD1(r, method, t1)                      \
   r method(t1 a1) const override {                             \
     ConstMethodCall1<C, r, t1> call(c_.get(), &C::method, a1); \
-    return call.Marshal(owner_thread_);                        \
+    return call.Marshal(signaling_thread_);                    \
   }
 
 #define PROXY_METHOD2(r, method, t1, t2)                          \
   r method(t1 a1, t2 a2) override {                               \
     MethodCall2<C, r, t1, t2> call(c_.get(), &C::method, a1, a2); \
-    return call.Marshal(owner_thread_);                           \
+    return call.Marshal(signaling_thread_);                       \
   }
 
 #define PROXY_METHOD3(r, method, t1, t2, t3)                              \
   r method(t1 a1, t2 a2, t3 a3) override {                                \
     MethodCall3<C, r, t1, t2, t3> call(c_.get(), &C::method, a1, a2, a3); \
-    return call.Marshal(owner_thread_);                                   \
+    return call.Marshal(signaling_thread_);                               \
   }
 
 #define PROXY_METHOD4(r, method, t1, t2, t3, t4)                             \
   r method(t1 a1, t2 a2, t3 a3, t4 a4) override {                            \
     MethodCall4<C, r, t1, t2, t3, t4> call(c_.get(), &C::method, a1, a2, a3, \
                                            a4);                              \
-    return call.Marshal(owner_thread_);                                      \
+    return call.Marshal(signaling_thread_);                                  \
   }
 
 #define PROXY_METHOD5(r, method, t1, t2, t3, t4, t5)                         \
   r method(t1 a1, t2 a2, t3 a3, t4 a4, t5 a5) override {                     \
     MethodCall5<C, r, t1, t2, t3, t4, t5> call(c_.get(), &C::method, a1, a2, \
                                                a3, a4, a5);                  \
-    return call.Marshal(owner_thread_);                                      \
+    return call.Marshal(signaling_thread_);                                  \
+  }
+
+// Define methods which should be invoked on the worker thread.
+#define PROXY_WORKER_METHOD1(r, method, t1)               \
+  r method(t1 a1) override {                              \
+    MethodCall1<C, r, t1> call(c_.get(), &C::method, a1); \
+    return call.Marshal(worker_thread_);                  \
+  }
+
+#define PROXY_WORKER_METHOD2(r, method, t1, t2)                   \
+  r method(t1 a1, t2 a2) override {                               \
+    MethodCall2<C, r, t1, t2> call(c_.get(), &C::method, a1, a2); \
+    return call.Marshal(worker_thread_);                          \
   }
 
 #define END_PROXY() \
    private:\
     void Release_s() {\
       c_ = NULL;\
     }\
-    mutable rtc::Thread* owner_thread_;\
+    mutable rtc::Thread* signaling_thread_;\
     rtc::scoped_refptr<C> c_;\
   };\
 
+#define END_WORKER_PROXY()                           \
+   private:                                          \
+    void Release_s() {                               \
+      c_ = NULL;                                     \
+    }                                                \
+    mutable rtc::Thread* signaling_thread_;          \
+    mutable rtc::Thread* worker_thread_;             \
+    rtc::scoped_refptr<C> c_;                        \
+  };                                                 \
+
 }  // namespace webrtc
 
 #endif  //  WEBRTC_API_PROXY_H_