Extended proxy abstraction, to call certain methods to the worker thread.

webrtc/api/videotracksource.cc

 /*
  *  Copyright 2016 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
 #include "webrtc/api/videotracksource.h"
 
 #include <string>
 
-#include "webrtc/base/bind.h"
-
 namespace webrtc {
 
 VideoTrackSource::VideoTrackSource(
     rtc::VideoSourceInterface<cricket::VideoFrame>* source,
     rtc::Thread* worker_thread,
     bool remote)
     : source_(source),
       worker_thread_(worker_thread),
       state_(kInitializing),
       remote_(remote) {}
 
 void VideoTrackSource::SetState(SourceState new_state) {
   if (state_ != new_state) {
     state_ = new_state;
     FireOnChanged();
   }
 }
 
 void VideoTrackSource::OnSourceDestroyed() {
   source_ = nullptr;
 }
 
 void VideoTrackSource::AddOrUpdateSink(
     rtc::VideoSinkInterface<cricket::VideoFrame>* sink,
     const rtc::VideoSinkWants& wants) {
+  RTC_CHECK(worker_thread_->IsCurrent());

[nisse-webrtc, 2016/04/05 10:13:46]

These RTC_CHECKs are now the only use of |worker_thread_|. Delete
worker_thread_, and replace by an rtc::ThreadChecker?

[perkj_webrtc, 2016/04/05 11:02:37]

yes please and name accordingly.

[nisse-webrtc, 2016/04/05 11:43:55]

I'm deleting the constructor argument as well (there's no obvious way to use it
to initialize the thread checker). Have to add a worker_thread_ variable in the
VideoCapturerTrackSource instead.

   if (!source_) {
     return;
   }
-  worker_thread_->Invoke<void>(rtc::Bind(
-      &rtc::VideoSourceInterface<cricket::VideoFrame>::AddOrUpdateSink, source_,
-      sink, wants));
+  source_->AddOrUpdateSink(sink, wants);
 }
 
 void VideoTrackSource::RemoveSink(
     rtc::VideoSinkInterface<cricket::VideoFrame>* sink) {
+  RTC_CHECK(worker_thread_->IsCurrent());
   if (!source_) {
     return;
   }
-  worker_thread_->Invoke<void>(
-      rtc::Bind(&rtc::VideoSourceInterface<cricket::VideoFrame>::RemoveSink,
-                source_, sink));
+  source_->RemoveSink(sink);
 }
 
 }  //  namespace webrtc