Revert of Set defines for Chromium build.

Revert of Set defines for Chromium build. (patchset #3 id:40001 of https://codereview.webrtc.org/1847013002/ )

Reason for revert:
This breaks remoting_unittests on Windows in Chromium:
[5116:2536:0404/012329:5457156:ERROR:webrtcsession.cc(1388)] ConnectDataChannel called when data_channel_ is NULL.
[5116:2536:0404/012329:5457187:ERROR:opensslidentity.cc(154)] Generating certificate: error:0c000071:ASN.1 encoding routines:OPENSSL_internal:ERROR_GETTING_TIME

[5116:2536:0404/012329:5457218:ERROR:opensslidentity.cc(154)] Generating certificate: error:0c000071:ASN.1 encoding routines:OPENSSL_internal:ERROR_GETTING_TIME

[5116:2536:0404/012329:5457218:WARNING:dtlsidentitystore.cc(221)] Failed to generate DTLS identity.
[

Original issue's description:
> Set defines for Chromium build.
>
> Copy the defines from the target_defaults section of Chromium's
> src/third_party/libjingle.gyp into our webrtc/build/common.gypi
> in order to ensure the same defines are used for the Chromium build
> when removing the source listings in src/third_party/libjingle.gyp.
> With this CL landed, it should be possible to replace them with
> dependencies on:
> * webrtc/api/api.gyp:libjingle_peerconnections
> * webrtc/media/media.gyp:rtc_media
> * webrtc/pc/pc.gyp:rtc_pc
> * webrtc/pp2/p2p.gyp:rtc_p2p
> * webrtc/libjingle/xmpp/xmpp.gyp:rtc_xmpp
>
> Not ported (Windows specific):
> * Precompiled headers (build/win_precompile.gypi):
>   since it only seems to offer a compile speedup. Will be landed
>   for all of WebRTC in separate CL.
>
> BUG=webrtc:4256
> NOTRY=True
> R=perkj@webrtc.org, tommi@webrtc.org
>
> Committed: https://chromium.googlesource.com/external/webrtc/+/9266cc066845c5d5be6551c583dcc831a2a47b67

TBR=perkj@webrtc.org,tommi@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:4256
Committed: https://crrev.com/602f41e2edcd0b555a492b074e1e3f7a01a89ede
Cr-Commit-Position: refs/heads/master@{#12229}

[kjellander_webrtc, 2016-04-05 06:39:23]

Created Revert of Set defines for Chromium build.

[kjellander_webrtc, 2016-04-05 06:39:30]

The CQ bit was checked by kjellander@webrtc.org

[commit-bot: I haz the power, 2016-04-05 06:39:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1861603002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1861603002/1

[commit-bot: I haz the power, 2016-04-05 06:39:48]

Description was changed from

==========
Revert of Set defines for Chromium build. (patchset #3 id:40001 of
https://codereview.webrtc.org/1847013002/ )

Reason for revert:
This breaks remoting_unittests on Windows in Chromium:
[5116:2536:0404/012329:5457156:ERROR:webrtcsession.cc(1388)] ConnectDataChannel
called when data_channel_ is NULL.
[5116:2536:0404/012329:5457187:ERROR:opensslidentity.cc(154)] Generating
certificate: error:0c000071:ASN.1 encoding
routines:OPENSSL_internal:ERROR_GETTING_TIME

[5116:2536:0404/012329:5457218:ERROR:opensslidentity.cc(154)] Generating
certificate: error:0c000071:ASN.1 encoding
routines:OPENSSL_internal:ERROR_GETTING_TIME

[5116:2536:0404/012329:5457218:WARNING:dtlsidentitystore.cc(221)] Failed to
generate DTLS identity.
[

Original issue's description:
> Set defines for Chromium build.
> 
> Copy the defines from the target_defaults section of Chromium's
> src/third_party/libjingle.gyp into our webrtc/build/common.gypi
> in order to ensure the same defines are used for the Chromium build
> when removing the source listings in src/third_party/libjingle.gyp.
> With this CL landed, it should be possible to replace them with
> dependencies on:
> * webrtc/api/api.gyp:libjingle_peerconnections
> * webrtc/media/media.gyp:rtc_media
> * webrtc/pc/pc.gyp:rtc_pc
> * webrtc/pp2/p2p.gyp:rtc_p2p
> * webrtc/libjingle/xmpp/xmpp.gyp:rtc_xmpp
> 
> Not ported (Windows specific):
> * Precompiled headers (build/win_precompile.gypi):
>   since it only seems to offer a compile speedup. Will be landed
>   for all of WebRTC in separate CL.
> 
> BUG=webrtc:4256
> NOTRY=True
> R=perkj@webrtc.org, tommi@webrtc.org
> 
> Committed:
https://chromium.googlesource.com/external/webrtc/+/9266cc066845c5d5be6551c58...

TBR=perkj@webrtc.org,tommi@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:4256
==========

to

==========
Revert of Set defines for Chromium build. (patchset #3 id:40001 of
https://codereview.webrtc.org/1847013002/ )

Reason for revert:
This breaks remoting_unittests on Windows in Chromium:
[5116:2536:0404/012329:5457156:ERROR:webrtcsession.cc(1388)] ConnectDataChannel
called when data_channel_ is NULL.
[5116:2536:0404/012329:5457187:ERROR:opensslidentity.cc(154)] Generating
certificate: error:0c000071:ASN.1 encoding
routines:OPENSSL_internal:ERROR_GETTING_TIME

[5116:2536:0404/012329:5457218:ERROR:opensslidentity.cc(154)] Generating
certificate: error:0c000071:ASN.1 encoding
routines:OPENSSL_internal:ERROR_GETTING_TIME

[5116:2536:0404/012329:5457218:WARNING:dtlsidentitystore.cc(221)] Failed to
generate DTLS identity.
[

Original issue's description:
> Set defines for Chromium build.
> 
> Copy the defines from the target_defaults section of Chromium's
> src/third_party/libjingle.gyp into our webrtc/build/common.gypi
> in order to ensure the same defines are used for the Chromium build
> when removing the source listings in src/third_party/libjingle.gyp.
> With this CL landed, it should be possible to replace them with
> dependencies on:
> * webrtc/api/api.gyp:libjingle_peerconnections
> * webrtc/media/media.gyp:rtc_media
> * webrtc/pc/pc.gyp:rtc_pc
> * webrtc/pp2/p2p.gyp:rtc_p2p
> * webrtc/libjingle/xmpp/xmpp.gyp:rtc_xmpp
> 
> Not ported (Windows specific):
> * Precompiled headers (build/win_precompile.gypi):
>   since it only seems to offer a compile speedup. Will be landed
>   for all of WebRTC in separate CL.
> 
> BUG=webrtc:4256
> NOTRY=True
> R=perkj@webrtc.org, tommi@webrtc.org
> 
> Committed:
https://chromium.googlesource.com/external/webrtc/+/9266cc066845c5d5be6551c58...

TBR=perkj@webrtc.org,tommi@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:4256
==========

[commit-bot: I haz the power, 2016-04-05 06:39:49]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-04-05 06:39:54]

Description was changed from

==========
Revert of Set defines for Chromium build. (patchset #3 id:40001 of
https://codereview.webrtc.org/1847013002/ )

Reason for revert:
This breaks remoting_unittests on Windows in Chromium:
[5116:2536:0404/012329:5457156:ERROR:webrtcsession.cc(1388)] ConnectDataChannel
called when data_channel_ is NULL.
[5116:2536:0404/012329:5457187:ERROR:opensslidentity.cc(154)] Generating
certificate: error:0c000071:ASN.1 encoding
routines:OPENSSL_internal:ERROR_GETTING_TIME

[5116:2536:0404/012329:5457218:ERROR:opensslidentity.cc(154)] Generating
certificate: error:0c000071:ASN.1 encoding
routines:OPENSSL_internal:ERROR_GETTING_TIME

[5116:2536:0404/012329:5457218:WARNING:dtlsidentitystore.cc(221)] Failed to
generate DTLS identity.
[

Original issue's description:
> Set defines for Chromium build.
> 
> Copy the defines from the target_defaults section of Chromium's
> src/third_party/libjingle.gyp into our webrtc/build/common.gypi
> in order to ensure the same defines are used for the Chromium build
> when removing the source listings in src/third_party/libjingle.gyp.
> With this CL landed, it should be possible to replace them with
> dependencies on:
> * webrtc/api/api.gyp:libjingle_peerconnections
> * webrtc/media/media.gyp:rtc_media
> * webrtc/pc/pc.gyp:rtc_pc
> * webrtc/pp2/p2p.gyp:rtc_p2p
> * webrtc/libjingle/xmpp/xmpp.gyp:rtc_xmpp
> 
> Not ported (Windows specific):
> * Precompiled headers (build/win_precompile.gypi):
>   since it only seems to offer a compile speedup. Will be landed
>   for all of WebRTC in separate CL.
> 
> BUG=webrtc:4256
> NOTRY=True
> R=perkj@webrtc.org, tommi@webrtc.org
> 
> Committed:
https://chromium.googlesource.com/external/webrtc/+/9266cc066845c5d5be6551c58...

TBR=perkj@webrtc.org,tommi@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:4256
==========

to

==========
Revert of Set defines for Chromium build. (patchset #3 id:40001 of
https://codereview.webrtc.org/1847013002/ )

Reason for revert:
This breaks remoting_unittests on Windows in Chromium:
[5116:2536:0404/012329:5457156:ERROR:webrtcsession.cc(1388)] ConnectDataChannel
called when data_channel_ is NULL.
[5116:2536:0404/012329:5457187:ERROR:opensslidentity.cc(154)] Generating
certificate: error:0c000071:ASN.1 encoding
routines:OPENSSL_internal:ERROR_GETTING_TIME

[5116:2536:0404/012329:5457218:ERROR:opensslidentity.cc(154)] Generating
certificate: error:0c000071:ASN.1 encoding
routines:OPENSSL_internal:ERROR_GETTING_TIME

[5116:2536:0404/012329:5457218:WARNING:dtlsidentitystore.cc(221)] Failed to
generate DTLS identity.
[

Original issue's description:
> Set defines for Chromium build.
>
> Copy the defines from the target_defaults section of Chromium's
> src/third_party/libjingle.gyp into our webrtc/build/common.gypi
> in order to ensure the same defines are used for the Chromium build
> when removing the source listings in src/third_party/libjingle.gyp.
> With this CL landed, it should be possible to replace them with
> dependencies on:
> * webrtc/api/api.gyp:libjingle_peerconnections
> * webrtc/media/media.gyp:rtc_media
> * webrtc/pc/pc.gyp:rtc_pc
> * webrtc/pp2/p2p.gyp:rtc_p2p
> * webrtc/libjingle/xmpp/xmpp.gyp:rtc_xmpp
>
> Not ported (Windows specific):
> * Precompiled headers (build/win_precompile.gypi):
>   since it only seems to offer a compile speedup. Will be landed
>   for all of WebRTC in separate CL.
>
> BUG=webrtc:4256
> NOTRY=True
> R=perkj@webrtc.org, tommi@webrtc.org
>
> Committed:
https://chromium.googlesource.com/external/webrtc/+/9266cc066845c5d5be6551c58...

TBR=perkj@webrtc.org,tommi@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:4256

Committed: https://crrev.com/602f41e2edcd0b555a492b074e1e3f7a01a89ede
Cr-Commit-Position: refs/heads/master@{#12229}
==========

[commit-bot: I haz the power, 2016-04-05 06:39:55]

Patchset 1 (id:??) landed as
https://crrev.com/602f41e2edcd0b555a492b074e1e3f7a01a89ede
Cr-Commit-Position: refs/heads/master@{#12229}

[kjellander_webrtc, 2016-04-05 06:40:05]

On 2016/04/05 06:39:23, kjellander (webrtc) wrote:
> Created Revert of Set defines for Chromium build.

See
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Win10%20Tester/buil...
for examples