Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 1860423002: Changed PeerConnectionEndToEndTest to use a separate worker thread. (Closed)

Created:
4 years, 8 months ago by perkj_webrtc
Modified:
4 years, 8 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Changed PeerConnectionEndToEndTest to use a separate worker thread. This is a follow up to https://codereview.webrtc.org/1859933002 to change this test also to use a separate worker thread. PeerConnectionEndToEndTest currently use the current thread both as a signaling thread and a worker thread. Although convenient while debugging, it can also hide real bugs. An example is https://codereview.webrtc.org/1766653002/#ps420001 where the worker thread is deadlocked in the track proxy due to that the worker thread waits for the signaling thread but the proxy in turns invokes the worker thread..... That bug was only discovered on Android. BUG=webrtc:5426 Committed: https://crrev.com/57db65255cc6004e3d82225fa4d2df565f169497 Cr-Commit-Position: refs/heads/master@{#12295}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -11 lines) Patch
M webrtc/api/peerconnectionendtoend_unittest.cc View 3 chunks +8 lines, -5 lines 0 comments Download
M webrtc/api/test/peerconnectiontestwrapper.h View 2 chunks +3 lines, -1 line 0 comments Download
M webrtc/api/test/peerconnectiontestwrapper.cc View 2 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
perkj_webrtc
Please?
4 years, 8 months ago (2016-04-06 08:15:21 UTC) #3
Taylor Brandstetter
lgtm
4 years, 8 months ago (2016-04-06 19:01:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1860423002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1860423002/20001
4 years, 8 months ago (2016-04-08 14:20:38 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 8 months ago (2016-04-08 15:16:39 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-08 15:16:50 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/57db65255cc6004e3d82225fa4d2df565f169497
Cr-Commit-Position: refs/heads/master@{#12295}

Powered by Google App Engine
This is Rietveld 408576698