Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1859713002: Re-enable NoiseSuppressionBitExactnessTest (Closed)

Created:
4 years, 8 months ago by aluebs-webrtc
Modified:
4 years, 8 months ago
Reviewers:
peah-webrtc
CC:
webrtc-reviews_webrtc.org, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Re-enable NoiseSuppressionBitExactnessTest they were disabled here: https://codereview.webrtc.org/1821443003/ BUG=webrtc:5728 Committed: https://crrev.com/853c8408018f7fef88abc6df50cbc1118cd66566 Cr-Commit-Position: refs/heads/master@{#12245}

Patch Set 1 #

Patch Set 2 : Fix ARM #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -32 lines) Patch
M webrtc/modules/audio_processing/noise_suppression_unittest.cc View 1 8 chunks +56 lines, -32 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
aluebs-webrtc
4 years, 8 months ago (2016-04-04 21:58:36 UTC) #3
peah-webrtc
On 2016/04/04 21:58:36, aluebs-webrtc wrote: lgtm
4 years, 8 months ago (2016-04-05 08:56:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1859713002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1859713002/20001
4 years, 8 months ago (2016-04-05 17:01:58 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-05 17:03:37 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-05 17:03:54 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/853c8408018f7fef88abc6df50cbc1118cd66566
Cr-Commit-Position: refs/heads/master@{#12245}

Powered by Google App Engine
This is Rietveld 408576698