Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(682)

Issue 1859413002: Delete unused code in rtc timeutils. (Closed)

Created:
4 years, 8 months ago by nisse-webrtc
Modified:
4 years, 8 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Delete unused code in rtc timeutils. BUG=webrtc:5740 Committed: https://crrev.com/b0c293c5abdf8a9a60da6ff3575a8e9ccea9d215 Cr-Commit-Position: refs/heads/master@{#12275}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Deleted a TODO comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -131 lines) Patch
M webrtc/base/timeutils.h View 1 3 chunks +0 lines, -15 lines 0 comments Download
M webrtc/base/timeutils.cc View 2 chunks +0 lines, -86 lines 0 comments Download
M webrtc/base/timeutils_unittest.cc View 2 chunks +0 lines, -30 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
nisse-webrtc
I haven't yet understood the duplication with webrtc::Clock, maybe some of the deleted functions could ...
4 years, 8 months ago (2016-04-06 13:44:05 UTC) #2
sprang
lgtm There's a lot of duplication from a time when those clocks lived in different ...
4 years, 8 months ago (2016-04-06 14:08:53 UTC) #4
perkj_webrtc
lgtm https://codereview.webrtc.org/1859413002/diff/1/webrtc/base/timeutils.h File webrtc/base/timeutils.h (right): https://codereview.webrtc.org/1859413002/diff/1/webrtc/base/timeutils.h#newcode63 webrtc/base/timeutils.h:63: // TODO(nisse): Unused, but kept for symmetry with ...
4 years, 8 months ago (2016-04-07 05:31:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1859413002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1859413002/20001
4 years, 8 months ago (2016-04-07 08:03:17 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-07 09:12:11 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-07 09:12:21 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b0c293c5abdf8a9a60da6ff3575a8e9ccea9d215
Cr-Commit-Position: refs/heads/master@{#12275}

Powered by Google App Engine
This is Rietveld 408576698