Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 1858873003: Revert of Moved the ringbuffer to be built using C++ (Closed)

Created:
4 years, 8 months ago by peah-webrtc
Modified:
4 years, 8 months ago
CC:
webrtc-reviews_webrtc.org, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Base URL:
https://chromium.googlesource.com/external/webrtc.git@MoveRingBuffer_CL
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Moved the ringbuffer to be built using C++ (patchset #2 id:20001 of https://codereview.webrtc.org/1851873003/ ) Reason for revert: This CL is dependent on the CL https://codereview.webrtc.org/1846903004/ which caused a google3 breakage due to dependencies in Google3. I will fix that, and reland this CL. Original issue's description: > Moved the ringbuffer to be built using C++ > > BUG=webrtc:5724 > > Committed: https://crrev.com/677e5774eaf287fa02f75fd5c8ad3f9ded9ed9c4 > Cr-Commit-Position: refs/heads/master@{#12230} TBR=ivoc@webrtc.org,henrik.lundin@webrtc.org,kwiberg@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:5724 Committed: https://crrev.com/6c393244b0dbd9d690bb03f90cd232b7b1994368 Cr-Commit-Position: refs/heads/master@{#12231}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+254 lines, -249 lines) Patch
M webrtc/modules/audio_processing/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_processing/aec/aec_core.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_processing/aec/aec_core_internal.h View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/modules/audio_processing/aec/echo_cancellation_internal.h View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/modules/audio_processing/audio_processing.gypi View 1 chunk +1 line, -1 line 0 comments Download
A webrtc/modules/audio_processing/utility/ring_buffer.c View 1 chunk +247 lines, -0 lines 0 comments Download
D webrtc/modules/audio_processing/utility/ring_buffer.cc View 1 chunk +0 lines, -246 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
peah-webrtc
Created Revert of Moved the ringbuffer to be built using C++
4 years, 8 months ago (2016-04-05 07:00:29 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1858873003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1858873003/1
4 years, 8 months ago (2016-04-05 07:00:40 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-05 07:00:48 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/6c393244b0dbd9d690bb03f90cd232b7b1994368 Cr-Commit-Position: refs/heads/master@{#12231}
4 years, 8 months ago (2016-04-05 07:00:54 UTC) #6
hlundin-webrtc
lgtm
4 years, 8 months ago (2016-04-05 07:23:58 UTC) #7
ivoc
4 years, 8 months ago (2016-04-05 07:29:14 UTC) #8
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698