Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 1858633002: PRESUBMIT: Update PyLint blacklist (Closed)

Created:
4 years, 8 months ago by kjellander_webrtc
Modified:
4 years, 8 months ago
Reviewers:
phoglund
CC:
webrtc-reviews_webrtc.org, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

PRESUBMIT: Update PyLint blacklist The PyLint was unnecessary slow due to some directories that don't belong to our repo. TESTED=Passing 'git cl presubmit' on Windows. NOTRY=True Committed: https://crrev.com/d620f820c903c77c56e567e274a4b9a89056b66f Cr-Commit-Position: refs/heads/master@{#12217}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M PRESUBMIT.py View 1 chunk +3 lines, -3 lines 1 comment Download

Messages

Total messages: 10 (5 generated)
kjellander_webrtc
https://codereview.webrtc.org/1858633002/diff/1/PRESUBMIT.py File PRESUBMIT.py (left): https://codereview.webrtc.org/1858633002/diff/1/PRESUBMIT.py#oldcode417 PRESUBMIT.py:417: r'^google_apis[\\\/].*\.py$', These three no longer exists.
4 years, 8 months ago (2016-04-04 12:40:27 UTC) #2
phoglund
lgtm
4 years, 8 months ago (2016-04-04 12:52:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1858633002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1858633002/1
4 years, 8 months ago (2016-04-04 13:04:52 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-04 13:07:12 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-04 13:07:19 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d620f820c903c77c56e567e274a4b9a89056b66f
Cr-Commit-Position: refs/heads/master@{#12217}

Powered by Google App Engine
This is Rietveld 408576698