Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 1858213002: Improves error handling for playout initialization on Android (Closed)

Created:
4 years, 8 months ago by henrika_webrtc
Modified:
4 years, 8 months ago
Reviewers:
magjed_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, audio-team_agora.io, sdk-team_agora.io, peah-webrtc, henrika_webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Improves error handling for playout initialization on Android. We no longer crash when initialization fails. BUG= Committed: https://crrev.com/ef38b564ea837b36731cb8bf01ee1006ff3b31a6 Cr-Commit-Position: refs/heads/master@{#12241}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -11 lines) Patch
M webrtc/modules/audio_device/android/audio_track_jni.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_device/android/audio_track_jni.cc View 3 chunks +8 lines, -5 lines 0 comments Download
M webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioTrack.java View 2 chunks +15 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
henrika_webrtc
As discussed off-line. PTAL.
4 years, 8 months ago (2016-04-05 11:40:21 UTC) #3
magjed_webrtc
lgtm
4 years, 8 months ago (2016-04-05 11:43:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1858213002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1858213002/1
4 years, 8 months ago (2016-04-05 11:48:20 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-05 14:20:32 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-05 14:20:42 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ef38b564ea837b36731cb8bf01ee1006ff3b31a6
Cr-Commit-Position: refs/heads/master@{#12241}

Powered by Google App Engine
This is Rietveld 408576698