Do not stop a session unless the candidate of a writable connection belongs to the

Do not stop a session unless the candidate of a writable connection belongs to the
latest generation.

BUG=webrtc:5644
R=deadbeef@webrtc.org, pthatcher@webrtc.org

Committed: https://crrev.com/5a2463796e3af75eec36b953878f4ce536240af3
Cr-Commit-Position: refs/heads/master@{#12599}

[honghaiz3, 2016-04-01 22:06:29]

honghaiz@webrtc.org changed reviewers:
+ deadbeef@webrtc.org, pthatcher@webrtc.org

[honghaiz3, 2016-04-01 22:06:29]

This should fix most of the issues that the gathering ends too early when there
are two back-to-back sessions. 
Let me know if you are OK with the solution.

[Taylor Brandstetter, 2016-04-01 22:10:51]

lgtm. May want to fix "generatin" typo in the description though.

[honghaiz3, 2016-04-01 23:35:17]

Description was changed from

==========
Do not stop a session unless the candidate of a writable connection belongs to
the
latest generatin.

BUG=webrtc:5644
==========

to

==========
Do not stop a session unless the candidate of a writable connection belongs to
the
latest generation.

BUG=webrtc:5644
==========

[honghaiz3, 2016-04-01 23:36:51]

Added tests

[pthatcher1, 2016-04-11 19:35:21]

https://codereview.webrtc.org/1857453002/diff/20001/webrtc/p2p/base/p2ptransp...
File webrtc/p2p/base/p2ptransportchannel.cc (right):

https://codereview.webrtc.org/1857453002/diff/20001/webrtc/p2p/base/p2ptransp...
webrtc/p2p/base/p2ptransportchannel.cc:1409: allocator_session()->generation())
{
Can you make a variable to improve readability?

bool strongly_connected = !connection->weak();
bool latest_generation = connection->local_candidate().generation() >=
allocator_session()->generation();
if (strongly_connected &&  latest_generation) {
  MaybeStopPortAllocatorSessions();
}

[honghaiz3, 2016-04-18 23:50:24]

Thanks!

https://codereview.webrtc.org/1857453002/diff/20001/webrtc/p2p/base/p2ptransp...
File webrtc/p2p/base/p2ptransportchannel.cc (right):

https://codereview.webrtc.org/1857453002/diff/20001/webrtc/p2p/base/p2ptransp...
webrtc/p2p/base/p2ptransportchannel.cc:1409: allocator_session()->generation())
{
On 2016/04/11 19:35:21, pthatcher1 wrote:
> Can you make a variable to improve readability?
> 
> bool strongly_connected = !connection->weak();
> bool latest_generation = connection->local_candidate().generation() >=
> allocator_session()->generation();
> if (strongly_connected &&  latest_generation) {
>   MaybeStopPortAllocatorSessions();
> }

Done.

[pthatcher1, 2016-05-02 16:41:19]

lgtm

[honghaiz3, 2016-05-02 18:16:50]

The CQ bit was checked by honghaiz@webrtc.org

[honghaiz3, 2016-05-02 18:16:51]

The patchset sent to the CQ was uploaded after l-g-t-m from deadbeef@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1857453002/#ps40001 (title:
"Add variables to improve readability")

[commit-bot: I haz the power, 2016-05-02 18:17:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1857453002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1857453002/40001

[commit-bot: I haz the power, 2016-05-02 20:17:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-02 20:17:33]

Try jobs failed on following builders:
  android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[honghaiz3, 2016-05-03 00:28:47]

Description was changed from

==========
Do not stop a session unless the candidate of a writable connection belongs to
the
latest generation.

BUG=webrtc:5644
==========

to

==========
Do not stop a session unless the candidate of a writable connection belongs to
the
latest generation.

BUG=webrtc:5644
R=deadbeef@webrtc.org, pthatcher@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/5a2463796e3af75eec36b9538...
==========

[honghaiz3, 2016-05-03 00:28:48]

Committed patchset #3 (id:40001) manually as
5a2463796e3af75eec36b953878f4ce536240af3 (presubmit successful).

[commit-bot: I haz the power, 2016-05-03 00:28:51]

Description was changed from

==========
Do not stop a session unless the candidate of a writable connection belongs to
the
latest generation.

BUG=webrtc:5644
R=deadbeef@webrtc.org, pthatcher@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/5a2463796e3af75eec36b9538...
==========

to

==========
Do not stop a session unless the candidate of a writable connection belongs to
the
latest generation.

BUG=webrtc:5644
R=deadbeef@webrtc.org, pthatcher@webrtc.org

Committed: https://crrev.com/5a2463796e3af75eec36b953878f4ce536240af3
Cr-Commit-Position: refs/heads/master@{#12599}
==========