VoE: Handle empty playout timestamp differently

VoE: Handle empty playout timestamp differently

With this change, the VoE Channel will handle the case of an empty
playout timestamp (from audio_coding_->PlayoutTimestamp())
differently. The purpose of the change is to prepare for an upcoming
change in NetEq where empty values will be returned more often (i.e.,
not only before the first packet is received).

BUG=webrtc:5669
Committed: https://crrev.com/96bd50262a20439fdd97fa273d052e20394930a3
Cr-Commit-Position: refs/heads/master@{#12261}

[hlundin-webrtc, 2016-04-05 11:52:49]

henrik.lundin@webrtc.org changed reviewers:
+ solenberg@webrtc.org

[hlundin-webrtc, 2016-04-05 11:52:50]

Fredrik,

Please, take a look at this CL.

[the sun, 2016-04-05 14:06:29]

https://codereview.webrtc.org/1857183002/diff/1/webrtc/voice_engine/channel.cc
File webrtc/voice_engine/channel.cc (right):

https://codereview.webrtc.org/1857183002/diff/1/webrtc/voice_engine/channel.c...
webrtc/voice_engine/channel.cc:3347: // timestamp, the resulting difference is
negative, but is set to zero.
AFAICT this comment is wrong now - you're not setting the difference to zero if
it is negative.

[hlundin-webrtc, 2016-04-05 14:34:23]

Fixing a comment

[hlundin-webrtc, 2016-04-05 14:35:15]

https://codereview.webrtc.org/1857183002/diff/1/webrtc/voice_engine/channel.cc
File webrtc/voice_engine/channel.cc (right):

https://codereview.webrtc.org/1857183002/diff/1/webrtc/voice_engine/channel.c...
webrtc/voice_engine/channel.cc:3347: // timestamp, the resulting difference is
negative, but is set to zero.
On 2016/04/05 14:06:29, the sun wrote:
> AFAICT this comment is wrong now - you're not setting the difference to zero
if
> it is negative.

Implicitly I still do. I changed the negation before IsNewerTimestamp, so now
the code reads as "if the diff is positive, set timestamp_diff_ms to something
other than the initial zero value."

I updated the comment.

[the sun, 2016-04-05 20:05:25]

On 2016/04/05 14:35:15, hlundin-webrtc wrote:
> https://codereview.webrtc.org/1857183002/diff/1/webrtc/voice_engine/channel.cc
> File webrtc/voice_engine/channel.cc (right):
> 
>
https://codereview.webrtc.org/1857183002/diff/1/webrtc/voice_engine/channel.c...
> webrtc/voice_engine/channel.cc:3347: // timestamp, the resulting difference is
> negative, but is set to zero.
> On 2016/04/05 14:06:29, the sun wrote:
> > AFAICT this comment is wrong now - you're not setting the difference to zero
> if
> > it is negative.
> 
> Implicitly I still do. I changed the negation before IsNewerTimestamp, so now
> the code reads as "if the diff is positive, set timestamp_diff_ms to something
> other than the initial zero value."
> 
> I updated the comment.

Ah, didn't notice it's an unsigned int.

[the sun, 2016-04-05 20:05:32]

lgtm

[hlundin-webrtc, 2016-04-06 08:44:55]

The CQ bit was checked by henrik.lundin@webrtc.org

[commit-bot: I haz the power, 2016-04-06 08:45:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1857183002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1857183002/20001

[commit-bot: I haz the power, 2016-04-06 11:14:01]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-06 11:14:06]

Description was changed from

==========
VoE: Handle empty playout timestamp differently

With this change, the VoE Channel will handle the case of an empty
playout timestamp (from audio_coding_->PlayoutTimestamp())
differently. The purpose of the change is to prepare for an upcoming
change in NetEq where empty values will be returned more often (i.e.,
not only before the first packet is received).

BUG=webrtc:5669
==========

to

==========
VoE: Handle empty playout timestamp differently

With this change, the VoE Channel will handle the case of an empty
playout timestamp (from audio_coding_->PlayoutTimestamp())
differently. The purpose of the change is to prepare for an upcoming
change in NetEq where empty values will be returned more often (i.e.,
not only before the first packet is received).

BUG=webrtc:5669

Committed: https://crrev.com/96bd50262a20439fdd97fa273d052e20394930a3
Cr-Commit-Position: refs/heads/master@{#12261}
==========

[commit-bot: I haz the power, 2016-04-06 11:14:07]

Patchset 2 (id:??) landed as
https://crrev.com/96bd50262a20439fdd97fa273d052e20394930a3
Cr-Commit-Position: refs/heads/master@{#12261}