Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: webrtc/p2p/base/transport_unittest.cc

Issue 1856943002: Allow TransportController to create a QuicTransportChannel (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Add unit tests to Transport Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/p2p/base/transport.cc ('k') | webrtc/p2p/base/transportcontroller.h » ('j') | webrtc/p2p/quic/quictransportchannel.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/p2p/base/transport_unittest.cc
diff --git a/webrtc/p2p/base/transport_unittest.cc b/webrtc/p2p/base/transport_unittest.cc
index 15bbe6edcf375eb92566ecd2da8eadd3788fb457..5982c3808c053c658f1e2dd7a48c476df3d55f40 100644
--- a/webrtc/p2p/base/transport_unittest.cc
+++ b/webrtc/p2p/base/transport_unittest.cc
@@ -233,3 +233,180 @@ TEST_F(TransportTest, TestGetStats) {
EXPECT_EQ(1, stats.channel_stats[0].component);
}
+// Tests that VerifyCertificateFingerprint only returns true when the
+// certificate matches the fingerprint.
+TEST_F(TransportTest, TestVerifyCertificateFingerprint) {
+ std::string error_desc;
+ EXPECT_FALSE(
+ transport_->VerifyCertificateFingerprint(nullptr, nullptr, &error_desc));
+ rtc::KeyType key_types[] = {rtc::KT_RSA, rtc::KT_ECDSA};
+
+ for (auto& key_type : key_types) {
+ rtc::scoped_refptr<rtc::RTCCertificate> certificate =
+ rtc::RTCCertificate::Create(rtc::scoped_ptr<rtc::SSLIdentity>(
+ rtc::SSLIdentity::Generate("testing", key_type)));
+ ASSERT_NE(nullptr, certificate);
+
+ std::string digest_algorithm;
+ ASSERT_TRUE(certificate->ssl_certificate().GetSignatureDigestAlgorithm(
+ &digest_algorithm));
+ ASSERT_FALSE(digest_algorithm.empty());
+ rtc::scoped_ptr<rtc::SSLFingerprint> good_fingerprint(
+ rtc::SSLFingerprint::Create(digest_algorithm, certificate->identity()));
+ ASSERT_NE(nullptr, good_fingerprint);
+
+ EXPECT_TRUE(transport_->VerifyCertificateFingerprint(
+ certificate.get(), good_fingerprint.get(), &error_desc));
+ EXPECT_FALSE(transport_->VerifyCertificateFingerprint(
+ certificate.get(), nullptr, &error_desc));
+ EXPECT_FALSE(transport_->VerifyCertificateFingerprint(
+ nullptr, good_fingerprint.get(), &error_desc));
+
+ rtc::SSLFingerprint bad_fingerprint = *good_fingerprint;
+ bad_fingerprint.digest.AppendData("0", 1);
+ EXPECT_FALSE(transport_->VerifyCertificateFingerprint(
+ certificate.get(), &bad_fingerprint, &error_desc));
+ }
+}
+
+// Tests that NegotiateRole sets the SSL role correctly.
+TEST_F(TransportTest, TestNegotiateRole) {
+ TransportDescription local_desc(kIceUfrag1, kIcePwd1);
+ TransportDescription remote_desc(kIceUfrag2, kIcePwd2);
+
+ struct NegotiateRoleParams {
+ cricket::ConnectionRole local_role;
+ cricket::ConnectionRole remote_role;
+ cricket::ContentAction local_action;
+ cricket::ContentAction remote_action;
+ };
+
+ rtc::SSLRole ssl_role;
+ std::string error_desc;
+
+ // Parameters which set the SSL role to SSL_CLIENT.
+ NegotiateRoleParams valid_client_params[] = {
+ {cricket::CONNECTIONROLE_ACTIVE, cricket::CONNECTIONROLE_ACTPASS,
+ cricket::CA_ANSWER, cricket::CA_OFFER},
+ {cricket::CONNECTIONROLE_ACTIVE, cricket::CONNECTIONROLE_ACTPASS,
+ cricket::CA_PRANSWER, cricket::CA_OFFER},
+ {cricket::CONNECTIONROLE_ACTPASS, cricket::CONNECTIONROLE_PASSIVE,
+ cricket::CA_OFFER, cricket::CA_ANSWER},
+ {cricket::CONNECTIONROLE_ACTPASS, cricket::CONNECTIONROLE_PASSIVE,
+ cricket::CA_OFFER, cricket::CA_PRANSWER}};
+
+ for (auto& param : valid_client_params) {
+ local_desc.connection_role = param.local_role;
+ remote_desc.connection_role = param.remote_role;
+
+ ASSERT_TRUE(transport_->SetRemoteTransportDescription(
+ remote_desc, param.remote_action, nullptr));
+ ASSERT_TRUE(transport_->SetLocalTransportDescription(
+ local_desc, param.local_action, nullptr));
+ EXPECT_TRUE(
+ transport_->NegotiateRole(param.local_action, &ssl_role, &error_desc));
+ EXPECT_EQ(rtc::SSL_CLIENT, ssl_role);
+ }
+
+ // Parameters which set the SSL role to SSL_SERVER.
+ NegotiateRoleParams valid_server_params[] = {
+ {cricket::CONNECTIONROLE_PASSIVE, cricket::CONNECTIONROLE_ACTPASS,
+ cricket::CA_ANSWER, cricket::CA_OFFER},
+ {cricket::CONNECTIONROLE_PASSIVE, cricket::CONNECTIONROLE_ACTPASS,
+ cricket::CA_PRANSWER, cricket::CA_OFFER},
+ {cricket::CONNECTIONROLE_ACTPASS, cricket::CONNECTIONROLE_ACTIVE,
+ cricket::CA_OFFER, cricket::CA_ANSWER},
+ {cricket::CONNECTIONROLE_ACTPASS, cricket::CONNECTIONROLE_ACTIVE,
+ cricket::CA_OFFER, cricket::CA_PRANSWER}};
+
+ for (auto& param : valid_server_params) {
+ local_desc.connection_role = param.local_role;
+ remote_desc.connection_role = param.remote_role;
+
+ ASSERT_TRUE(transport_->SetRemoteTransportDescription(
+ remote_desc, param.remote_action, nullptr));
+ ASSERT_TRUE(transport_->SetLocalTransportDescription(
+ local_desc, param.local_action, nullptr));
+ EXPECT_TRUE(
+ transport_->NegotiateRole(param.local_action, &ssl_role, &error_desc));
+ EXPECT_EQ(rtc::SSL_SERVER, ssl_role);
+ }
+
+ // Invalid parameters due to both peers having a duplicate role.
+ NegotiateRoleParams duplicate_params[] = {
+ {cricket::CONNECTIONROLE_ACTIVE, cricket::CONNECTIONROLE_ACTIVE,
+ cricket::CA_ANSWER, cricket::CA_OFFER},
+ {cricket::CONNECTIONROLE_ACTPASS, cricket::CONNECTIONROLE_ACTPASS,
+ cricket::CA_ANSWER, cricket::CA_OFFER},
+ {cricket::CONNECTIONROLE_PASSIVE, cricket::CONNECTIONROLE_PASSIVE,
+ cricket::CA_ANSWER, cricket::CA_OFFER},
+ {cricket::CONNECTIONROLE_ACTIVE, cricket::CONNECTIONROLE_ACTIVE,
+ cricket::CA_PRANSWER, cricket::CA_OFFER},
+ {cricket::CONNECTIONROLE_ACTPASS, cricket::CONNECTIONROLE_ACTPASS,
+ cricket::CA_PRANSWER, cricket::CA_OFFER},
+ {cricket::CONNECTIONROLE_PASSIVE, cricket::CONNECTIONROLE_PASSIVE,
+ cricket::CA_PRANSWER, cricket::CA_OFFER},
+ {cricket::CONNECTIONROLE_ACTIVE, cricket::CONNECTIONROLE_ACTIVE,
+ cricket::CA_OFFER, cricket::CA_ANSWER},
+ {cricket::CONNECTIONROLE_ACTPASS, cricket::CONNECTIONROLE_ACTPASS,
+ cricket::CA_OFFER, cricket::CA_ANSWER},
+ {cricket::CONNECTIONROLE_PASSIVE, cricket::CONNECTIONROLE_PASSIVE,
+ cricket::CA_OFFER, cricket::CA_ANSWER},
+ {cricket::CONNECTIONROLE_ACTIVE, cricket::CONNECTIONROLE_ACTIVE,
+ cricket::CA_OFFER, cricket::CA_PRANSWER},
+ {cricket::CONNECTIONROLE_ACTPASS, cricket::CONNECTIONROLE_ACTPASS,
+ cricket::CA_OFFER, cricket::CA_PRANSWER},
+ {cricket::CONNECTIONROLE_PASSIVE, cricket::CONNECTIONROLE_PASSIVE,
+ cricket::CA_OFFER, cricket::CA_PRANSWER}};
+
+ for (auto& param : duplicate_params) {
+ local_desc.connection_role = param.local_role;
+ remote_desc.connection_role = param.remote_role;
+
+ ASSERT_TRUE(transport_->SetRemoteTransportDescription(
+ remote_desc, param.remote_action, nullptr));
+ ASSERT_TRUE(transport_->SetLocalTransportDescription(
+ local_desc, param.local_action, nullptr));
+ EXPECT_FALSE(
+ transport_->NegotiateRole(param.local_action, &ssl_role, &error_desc));
+ }
+
+ // Invalid parameters due to the offerer not using ACTPASS.
+ NegotiateRoleParams offerer_without_actpass_params[] = {
+ {cricket::CONNECTIONROLE_ACTIVE, cricket::CONNECTIONROLE_PASSIVE,
+ cricket::CA_ANSWER, cricket::CA_OFFER},
+ {cricket::CONNECTIONROLE_PASSIVE, cricket::CONNECTIONROLE_ACTIVE,
+ cricket::CA_ANSWER, cricket::CA_OFFER},
+ {cricket::CONNECTIONROLE_ACTPASS, cricket::CONNECTIONROLE_PASSIVE,
+ cricket::CA_ANSWER, cricket::CA_OFFER},
+ {cricket::CONNECTIONROLE_ACTIVE, cricket::CONNECTIONROLE_PASSIVE,
+ cricket::CA_PRANSWER, cricket::CA_OFFER},
+ {cricket::CONNECTIONROLE_PASSIVE, cricket::CONNECTIONROLE_ACTIVE,
+ cricket::CA_PRANSWER, cricket::CA_OFFER},
+ {cricket::CONNECTIONROLE_ACTPASS, cricket::CONNECTIONROLE_PASSIVE,
+ cricket::CA_PRANSWER, cricket::CA_OFFER},
+ {cricket::CONNECTIONROLE_ACTIVE, cricket::CONNECTIONROLE_PASSIVE,
+ cricket::CA_OFFER, cricket::CA_ANSWER},
+ {cricket::CONNECTIONROLE_PASSIVE, cricket::CONNECTIONROLE_ACTIVE,
+ cricket::CA_OFFER, cricket::CA_ANSWER},
+ {cricket::CONNECTIONROLE_PASSIVE, cricket::CONNECTIONROLE_ACTPASS,
+ cricket::CA_OFFER, cricket::CA_ANSWER},
+ {cricket::CONNECTIONROLE_ACTIVE, cricket::CONNECTIONROLE_PASSIVE,
+ cricket::CA_OFFER, cricket::CA_PRANSWER},
+ {cricket::CONNECTIONROLE_PASSIVE, cricket::CONNECTIONROLE_ACTIVE,
+ cricket::CA_OFFER, cricket::CA_PRANSWER},
+ {cricket::CONNECTIONROLE_PASSIVE, cricket::CONNECTIONROLE_ACTPASS,
+ cricket::CA_OFFER, cricket::CA_PRANSWER}};
+
+ for (auto& param : offerer_without_actpass_params) {
+ local_desc.connection_role = param.local_role;
+ remote_desc.connection_role = param.remote_role;
+
+ ASSERT_TRUE(transport_->SetRemoteTransportDescription(
+ remote_desc, param.remote_action, nullptr));
+ ASSERT_TRUE(transport_->SetLocalTransportDescription(
+ local_desc, param.local_action, nullptr));
+ EXPECT_FALSE(
+ transport_->NegotiateRole(param.local_action, &ssl_role, &error_desc));
+ }
+}
« no previous file with comments | « webrtc/p2p/base/transport.cc ('k') | webrtc/p2p/base/transportcontroller.h » ('j') | webrtc/p2p/quic/quictransportchannel.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698