Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(872)

Unified Diff: webrtc/p2p/quic/quictransportchannel.h

Issue 1856513002: Add QuicTransportChannel methods for QUIC streams (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/p2p/quic/quictransportchannel.h
diff --git a/webrtc/p2p/quic/quictransportchannel.h b/webrtc/p2p/quic/quictransportchannel.h
index ab02c77b9526f19e2adefe702e5d762089358327..887bdcc9a39f7d0e3319ef358723391ac1f6fb2e 100644
--- a/webrtc/p2p/quic/quictransportchannel.h
+++ b/webrtc/p2p/quic/quictransportchannel.h
@@ -48,7 +48,7 @@ enum QuicTransportState {
// TransportChannelImpl* channel_;
// }
//
-// - Data written to SendPacket() is passed directly to |channel_| if it is
+// - Data written to SendPacket() is passed directly to |channel_| if it is
// an SRTP packet with the PF_SRTP_BYPASS flag.
//
// - |quic_| passes outgoing packets to WritePacket(), which transfers them
@@ -61,8 +61,11 @@ enum QuicTransportState {
// - When the QUIC handshake is completed, quic_state() returns
// QUIC_TRANSPORT_CONNECTED and SRTP keying material can be exported.
//
-// TODO(mikescarlett): Implement secure QUIC handshake, 0-RTT handshakes, and
-// QUIC data streams.
+// - CreateQuicStream() creates an outgoing QUIC stream. Once the local peer
+// sends data from this stream, the remote peer emits SignalIncomingStream
+// with a QUIC stream of the same id to handle received data.
+//
+// TODO(mikescarlett): Implement secure QUIC handshake and 0-RTT handshakes.
class QuicTransportChannel : public TransportChannelImpl,
public net::QuicPacketWriter,
public net::QuicCryptoClientStream::ProofHandler {
@@ -206,6 +209,14 @@ class QuicTransportChannel : public TransportChannelImpl,
void OnCanWrite();
// Connectivity state of QuicTransportChannel.
QuicTransportState quic_state() const { return quic_state_; }
+ // Creates a new QUIC stream that can send data.
+ ReliableQuicStream* CreateQuicStream();
+
+ // Emitted when |quic_| creates a QUIC stream to receive data from the remote
+ // peer, when the stream did not exist previously.
+ sigslot::signal1<ReliableQuicStream*> SignalIncomingStream;
+ // Emitted when the QuicTransportChannel state becomes QUIC_TRANSPORT_CLOSED.
+ sigslot::signal0<> SignalClosed;
private:
// Fingerprint of remote peer.
@@ -241,6 +252,8 @@ class QuicTransportChannel : public TransportChannelImpl,
void OnHandshakeComplete();
// Called when |quic_| has closed the connection.
void OnConnectionClosed(net::QuicErrorCode error, bool from_peer);
+ // Called when |quic_| has created a new QUIC stream for incoming data.
+ void OnIncomingStream(ReliableQuicStream* stream);
// Called by OnReadPacket() when a QUIC packet is received.
bool HandleQuicPacket(const char* data, size_t size);

Powered by Google App Engine
This is Rietveld 408576698