Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1163)

Unified Diff: webrtc/p2p/quic/reliablequicstream_unittest.cc

Issue 1856513002: Add QuicTransportChannel methods for QUIC streams (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Add back quicsession.h comment Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/p2p/quic/reliablequicstream.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/p2p/quic/reliablequicstream_unittest.cc
diff --git a/webrtc/p2p/quic/reliablequicstream_unittest.cc b/webrtc/p2p/quic/reliablequicstream_unittest.cc
index aeb3e1af87ce1f4049100f9205bd42d61c448eab..b8875894576a0f1836cdc84ca8c6df57bacca6c9 100644
--- a/webrtc/p2p/quic/reliablequicstream_unittest.cc
+++ b/webrtc/p2p/quic/reliablequicstream_unittest.cc
@@ -163,6 +163,8 @@ class ReliableQuicStreamTest : public ::testing::Test,
stream_->SignalDataReceived.connect(
this, &ReliableQuicStreamTest::OnDataReceived);
stream_->SignalClosed.connect(this, &ReliableQuicStreamTest::OnClosed);
+ stream_->SignalQueuedBytesWritten.connect(
+ this, &ReliableQuicStreamTest::OnQueuedBytesWritten);
session_->register_write_blocked_stream(stream_->id(), kDefaultPriority);
}
@@ -172,7 +174,11 @@ class ReliableQuicStreamTest : public ::testing::Test,
read_buffer_.append(data, length);
}
- void OnClosed(QuicStreamId id, QuicErrorCode err) { closed_ = true; }
+ void OnClosed(QuicStreamId id, int err) { closed_ = true; }
+
+ void OnQueuedBytesWritten(QuicStreamId id, uint64_t queued_bytes_written) {
+ queued_bytes_written_ = queued_bytes_written;
+ }
protected:
rtc::scoped_ptr<ReliableQuicStream> stream_;
@@ -184,6 +190,8 @@ class ReliableQuicStreamTest : public ::testing::Test,
std::string read_buffer_;
// Whether the ReliableQuicStream is closed.
bool closed_ = false;
+ // Bytes written by OnCanWrite().
+ uint64_t queued_bytes_written_;
};
// Write an entire string.
@@ -213,6 +221,7 @@ TEST_F(ReliableQuicStreamTest, BufferData) {
session_->set_writable(true);
stream_->OnCanWrite();
+ EXPECT_EQ(7ul, queued_bytes_written_);
EXPECT_FALSE(stream_->HasBufferedData());
EXPECT_EQ("Foo bar", write_buffer_);
« no previous file with comments | « webrtc/p2p/quic/reliablequicstream.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698