Add QuicTransportChannel methods for QUIC streams

Add QuicTransportChannel methods for QUIC streams

The QuicTransportChannel now creates outgoing QUIC streams
for sending a message, and incoming QUIC streams for
receiving a message. It also signals when the QUIC connection
closes.

Split from CL https://codereview.webrtc.org/1844803002/.

BUG=

Committed: https://crrev.com/18b67a59eaec2d3611ca88ecc5c878f557bda0b4
Cr-Commit-Position: refs/heads/master@{#12323}

[mikescarlett, 2016-04-04 18:27:21]

Description was changed from

==========
Add QuicTransportChannel methods for QUIC streams

BUG=
==========

to

==========
Add QuicTransportChannel methods for QUIC streams

The QuicTransportChannel now creates outgoing QUIC streams
for sending a message, and incoming QUIC streams for
receiving a message. It also signals when the QUIC connection
closes.

Split from CL https://codereview.webrtc.org/1844803002/.

BUG=
==========

[mikescarlett, 2016-04-04 18:27:21]

mikescarlett@webrtc.org changed reviewers:
+ deadbeef@webrtc.org, pthatcher@webrtc.org

[Taylor Brandstetter, 2016-04-05 22:19:35]

https://codereview.webrtc.org/1856513002/diff/80001/webrtc/p2p/quic/quictrans...
File webrtc/p2p/quic/quictransportchannel_unittest.cc (right):

https://codereview.webrtc.org/1856513002/diff/80001/webrtc/p2p/quic/quictrans...
webrtc/p2p/quic/quictransportchannel_unittest.cc:518:
TEST_F(QuicTransportChannelTest, SignalClosedEmmitted) {
Emmitted => Emitted

https://codereview.webrtc.org/1856513002/diff/80001/webrtc/p2p/quic/quictrans...
webrtc/p2p/quic/quictransportchannel_unittest.cc:527: }
Should this also wait for peer2_signal_closed_emitted?

[mikescarlett, 2016-04-06 17:31:54]

https://codereview.webrtc.org/1856513002/diff/80001/webrtc/p2p/quic/quictrans...
File webrtc/p2p/quic/quictransportchannel_unittest.cc (right):

https://codereview.webrtc.org/1856513002/diff/80001/webrtc/p2p/quic/quictrans...
webrtc/p2p/quic/quictransportchannel_unittest.cc:518:
TEST_F(QuicTransportChannelTest, SignalClosedEmmitted) {
On 2016/04/05 22:19:35, Taylor Brandstetter wrote:
> Emmitted => Emitted

Done.

https://codereview.webrtc.org/1856513002/diff/80001/webrtc/p2p/quic/quictrans...
webrtc/p2p/quic/quictransportchannel_unittest.cc:527: }
On 2016/04/05 22:19:35, Taylor Brandstetter wrote:
> Should this also wait for peer2_signal_closed_emitted?

Yes it should. Fixed.

[Taylor Brandstetter, 2016-04-06 19:06:42]

lgtm

[pthatcher1, 2016-04-11 22:02:11]

lgtm

https://codereview.webrtc.org/1856513002/diff/120001/webrtc/p2p/quic/quicsess...
File webrtc/p2p/quic/quicsession.h (left):

https://codereview.webrtc.org/1856513002/diff/120001/webrtc/p2p/quic/quicsess...
webrtc/p2p/quic/quicsession.h:52: // QuicConnectionVisitorInterface overrides.
I'm curious why this is removed.  Is this no longer true?

[mikescarlett, 2016-04-11 22:29:31]

https://codereview.webrtc.org/1856513002/diff/120001/webrtc/p2p/quic/quicsess...
File webrtc/p2p/quic/quicsession.h (left):

https://codereview.webrtc.org/1856513002/diff/120001/webrtc/p2p/quic/quicsess...
webrtc/p2p/quic/quicsession.h:52: // QuicConnectionVisitorInterface overrides.
On 2016/04/11 22:02:11, pthatcher1 wrote:
> I'm curious why this is removed.  Is this no longer true?  

I'm adding this back. This is still true.

[mikescarlett, 2016-04-11 22:29:58]

The CQ bit was checked by mikescarlett@webrtc.org

[mikescarlett, 2016-04-11 22:29:58]

The patchset sent to the CQ was uploaded after l-g-t-m from deadbeef@webrtc.org,
pthatcher@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1856513002/#ps140001 (title:
"Add back quicsession.h comment")

[commit-bot: I haz the power, 2016-04-11 22:30:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1856513002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1856513002/140001

[commit-bot: I haz the power, 2016-04-11 23:56:26]

Description was changed from

==========
Add QuicTransportChannel methods for QUIC streams

The QuicTransportChannel now creates outgoing QUIC streams
for sending a message, and incoming QUIC streams for
receiving a message. It also signals when the QUIC connection
closes.

Split from CL https://codereview.webrtc.org/1844803002/.

BUG=
==========

to

==========
Add QuicTransportChannel methods for QUIC streams

The QuicTransportChannel now creates outgoing QUIC streams
for sending a message, and incoming QUIC streams for
receiving a message. It also signals when the QUIC connection
closes.

Split from CL https://codereview.webrtc.org/1844803002/.

BUG=
==========

[commit-bot: I haz the power, 2016-04-11 23:56:27]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2016-04-11 23:56:34]

Description was changed from

==========
Add QuicTransportChannel methods for QUIC streams

The QuicTransportChannel now creates outgoing QUIC streams
for sending a message, and incoming QUIC streams for
receiving a message. It also signals when the QUIC connection
closes.

Split from CL https://codereview.webrtc.org/1844803002/.

BUG=
==========

to

==========
Add QuicTransportChannel methods for QUIC streams

The QuicTransportChannel now creates outgoing QUIC streams
for sending a message, and incoming QUIC streams for
receiving a message. It also signals when the QUIC connection
closes.

Split from CL https://codereview.webrtc.org/1844803002/.

BUG=

Committed: https://crrev.com/18b67a59eaec2d3611ca88ecc5c878f557bda0b4
Cr-Commit-Position: refs/heads/master@{#12323}
==========

[commit-bot: I haz the power, 2016-04-11 23:56:35]

Patchset 8 (id:??) landed as
https://crrev.com/18b67a59eaec2d3611ca88ecc5c878f557bda0b4
Cr-Commit-Position: refs/heads/master@{#12323}