Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(909)

Unified Diff: webrtc/api/java/android/org/webrtc/EglBase10.java

Issue 1855953002: Andoid EglBase: Detect failure to find EGL config (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Switch to more fine grained exceptions Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/api/java/android/org/webrtc/EglBase14.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/api/java/android/org/webrtc/EglBase10.java
diff --git a/webrtc/api/java/android/org/webrtc/EglBase10.java b/webrtc/api/java/android/org/webrtc/EglBase10.java
index fe2b73ee1cc2a542fbe8d5da6188d6609f7996ba..70f9eb73a65ff871574d9d72aa90567a0a0d1573 100644
--- a/webrtc/api/java/android/org/webrtc/EglBase10.java
+++ b/webrtc/api/java/android/org/webrtc/EglBase10.java
@@ -268,9 +268,16 @@ final class EglBase10 extends EglBase {
int[] numConfigs = new int[1];
if (!egl.eglChooseConfig(
eglDisplay, configAttributes, configs, configs.length, numConfigs)) {
+ throw new RuntimeException("eglChooseConfig failed");
+ }
+ if (numConfigs[0] <= 0) {
throw new RuntimeException("Unable to find any matching EGL config");
}
- return configs[0];
+ final EGLConfig eglConfig = configs[0];
+ if (eglConfig == null) {
+ throw new RuntimeException("eglChooseConfig returned null");
+ }
+ return eglConfig;
}
// Return an EGLConfig, or die trying.
« no previous file with comments | « no previous file | webrtc/api/java/android/org/webrtc/EglBase14.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698