Andoid EglBase: Detect failure to find EGL config

Andoid EglBase: Detect failure to find EGL config

BUG=b/27950559

Committed: https://crrev.com/9fdb6cf255afc6523b1dca7b04681a5778354c07
Cr-Commit-Position: refs/heads/master@{#12239}

[magjed_webrtc, 2016-04-04 13:07:47]

Description was changed from

==========
Andoid EglBase: Detect failure to find EGL config

BUG=b/27950559
==========

to

==========
Andoid EglBase: Detect failure to find EGL config

BUG=b/27950559
==========

[magjed_webrtc, 2016-04-04 13:07:47]

magjed@webrtc.org changed reviewers:
+ glaznev@webrtc.org

[magjed_webrtc, 2016-04-04 13:08:01]

Alex - please take a look.

[AlexG, 2016-04-04 17:13:59]

lgtm

https://codereview.webrtc.org/1855953002/diff/1/webrtc/api/java/android/org/w...
File webrtc/api/java/android/org/webrtc/EglBase10.java (right):

https://codereview.webrtc.org/1855953002/diff/1/webrtc/api/java/android/org/w...
webrtc/api/java/android/org/webrtc/EglBase10.java:273: throw new
RuntimeException("Unable to find any matching EGL config");
Add extra information to exception to understand what is failing - return code
is false or config is null?

https://codereview.webrtc.org/1855953002/diff/1/webrtc/api/java/android/org/w...
File webrtc/api/java/android/org/webrtc/EglBase14.java (right):

https://codereview.webrtc.org/1855953002/diff/1/webrtc/api/java/android/org/w...
webrtc/api/java/android/org/webrtc/EglBase14.java:232: if
(!eglChooseConfigSuccess || numConfigs[0] <= 0 || eglConfig == null) {
Same comment as for EGL10 - add a few extra information to exception?

[magjed_webrtc, 2016-04-05 10:48:27]

https://codereview.webrtc.org/1855953002/diff/1/webrtc/api/java/android/org/w...
File webrtc/api/java/android/org/webrtc/EglBase10.java (right):

https://codereview.webrtc.org/1855953002/diff/1/webrtc/api/java/android/org/w...
webrtc/api/java/android/org/webrtc/EglBase10.java:273: throw new
RuntimeException("Unable to find any matching EGL config");
On 2016/04/04 17:13:59, AlexG wrote:
> Add extra information to exception to understand what is failing - return code
> is false or config is null?

Done, I throw individual exceptions now for each failure.

[magjed_webrtc, 2016-04-05 10:48:31]

The CQ bit was checked by magjed@webrtc.org

[magjed_webrtc, 2016-04-05 10:48:32]

The patchset sent to the CQ was uploaded after l-g-t-m from glaznev@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1855953002/#ps20001 (title:
"Switch to more fine grained exceptions")

[commit-bot: I haz the power, 2016-04-05 10:48:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1855953002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1855953002/20001

[commit-bot: I haz the power, 2016-04-05 13:08:09]

Description was changed from

==========
Andoid EglBase: Detect failure to find EGL config

BUG=b/27950559
==========

to

==========
Andoid EglBase: Detect failure to find EGL config

BUG=b/27950559
==========

[commit-bot: I haz the power, 2016-04-05 13:08:10]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-05 13:08:20]

Description was changed from

==========
Andoid EglBase: Detect failure to find EGL config

BUG=b/27950559
==========

to

==========
Andoid EglBase: Detect failure to find EGL config

BUG=b/27950559

Committed: https://crrev.com/9fdb6cf255afc6523b1dca7b04681a5778354c07
Cr-Commit-Position: refs/heads/master@{#12239}
==========

[commit-bot: I haz the power, 2016-04-05 13:08:21]

Patchset 2 (id:??) landed as
https://crrev.com/9fdb6cf255afc6523b1dca7b04681a5778354c07
Cr-Commit-Position: refs/heads/master@{#12239}