Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1855433002: Replace NULL with nullptr in webrtc/video. (Closed)

Created:
4 years, 8 months ago by pbos-webrtc
Modified:
4 years, 8 months ago
Reviewers:
danilchap
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, the sun, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Replace NULL with nullptr in webrtc/video. BUG= R=danilchap@webrtc.org Committed: https://crrev.com/74f6e9ea2329a56d8e202f70d3a5bc6d9a7527d9 Cr-Commit-Position: refs/heads/master@{#12218}

Patch Set 1 #

Patch Set 2 : nit #

Total comments: 2

Patch Set 3 : replace x == nullptr with !x #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -109 lines) Patch
M webrtc/video/encoded_frame_callback_adapter.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video/end_to_end_tests.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/video/overuse_frame_detector.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/video/payload_router_unittest.cc View 5 chunks +27 lines, -27 lines 0 comments Download
M webrtc/video/receive_statistics_proxy.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video/replay.cc View 1 2 5 chunks +9 lines, -9 lines 0 comments Download
M webrtc/video/send_statistics_proxy.cc View 1 2 10 chunks +11 lines, -12 lines 0 comments Download
M webrtc/video/video_capture_input_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video/video_decoder.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video/video_quality_test.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M webrtc/video/video_receive_stream.cc View 1 2 5 chunks +7 lines, -7 lines 0 comments Download
M webrtc/video/video_send_stream.cc View 1 2 6 chunks +11 lines, -12 lines 0 comments Download
M webrtc/video/video_send_stream_tests.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M webrtc/video/vie_channel.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video/vie_channel.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/video/vie_encoder.cc View 1 2 4 chunks +6 lines, -6 lines 0 comments Download
M webrtc/video/vie_receiver.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M webrtc/video/vie_remb.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video/vie_sync_module.cc View 3 chunks +9 lines, -12 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
pbos-webrtc
PTAL
4 years, 8 months ago (2016-04-01 11:45:47 UTC) #1
pbos-webrtc
nit
4 years, 8 months ago (2016-04-01 11:52:43 UTC) #2
danilchap
lgtm https://codereview.webrtc.org/1855433002/diff/20001/webrtc/video/video_receive_stream.cc File webrtc/video/video_receive_stream.cc (right): https://codereview.webrtc.org/1855433002/diff/20001/webrtc/video/video_receive_stream.cc#newcode377 webrtc/video/video_receive_stream.cc:377: if (video_frame->native_handle() == nullptr) { may be, just ...
4 years, 8 months ago (2016-04-01 13:05:49 UTC) #3
pbos-webrtc
replace x == nullptr with !x
4 years, 8 months ago (2016-04-01 13:11:52 UTC) #4
pbos-webrtc
https://codereview.webrtc.org/1855433002/diff/20001/webrtc/video/video_receive_stream.cc File webrtc/video/video_receive_stream.cc (right): https://codereview.webrtc.org/1855433002/diff/20001/webrtc/video/video_receive_stream.cc#newcode377 webrtc/video/video_receive_stream.cc:377: if (video_frame->native_handle() == nullptr) { On 2016/04/01 13:05:49, danilchap ...
4 years, 8 months ago (2016-04-01 13:12:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1855433002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1855433002/40001
4 years, 8 months ago (2016-04-01 13:12:11 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 8 months ago (2016-04-01 15:12:43 UTC) #10
pbos-webrtc
Committed patchset #3 (id:40001) manually as 74f6e9ea2329a56d8e202f70d3a5bc6d9a7527d9 (presubmit successful).
4 years, 8 months ago (2016-04-04 15:56:28 UTC) #12
commit-bot: I haz the power
4 years, 8 months ago (2016-04-04 15:56:31 UTC) #14
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/74f6e9ea2329a56d8e202f70d3a5bc6d9a7527d9
Cr-Commit-Position: refs/heads/master@{#12218}

Powered by Google App Engine
This is Rietveld 408576698