Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(567)

Issue 1855393005: Remove QualityScaler kDefaultLowQpDenominator. (Closed)

Created:
4 years, 8 months ago by pbos-webrtc
Modified:
4 years, 8 months ago
Reviewers:
danilchap
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove QualityScaler kDefaultLowQpDenominator. This denominator doesn't make any semantic sense, it's better to use real thresholds for when things look "good" or "bad" rather than fractions of a max QP. BUG=webrtc:5678 R=danilchap@webrtc.org Committed: https://crrev.com/00b62b0849dd009498d0305ee77d4df70fe5e96b Cr-Commit-Position: refs/heads/master@{#12363}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -17 lines) Patch
M webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/video_coding/utility/quality_scaler.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/video_coding/utility/quality_scaler.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/modules/video_coding/utility/quality_scaler_unittest.cc View 1 6 chunks +9 lines, -12 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
pbos-webrtc
PTAL
4 years, 8 months ago (2016-04-06 15:23:37 UTC) #1
danilchap
lgtm
4 years, 8 months ago (2016-04-14 15:00:12 UTC) #5
pbos-webrtc
rebase
4 years, 8 months ago (2016-04-14 15:01:17 UTC) #6
pbos-webrtc
Committed patchset #2 (id:20001) manually as 00b62b0849dd009498d0305ee77d4df70fe5e96b (presubmit successful).
4 years, 8 months ago (2016-04-14 15:04:18 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-14 15:04:21 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/00b62b0849dd009498d0305ee77d4df70fe5e96b
Cr-Commit-Position: refs/heads/master@{#12363}

Powered by Google App Engine
This is Rietveld 408576698