Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1047)

Issue 1855393004: Revert of Moved ring-buffer related files from common_audio to audio_processing" (Closed)

Created:
4 years, 8 months ago by peah-webrtc
Modified:
4 years, 8 months ago
Reviewers:
ivoc, hlundin-webrtc
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Moved ring-buffer related files from common_audio to audio_processing" (patchset #2 id:20001 of https://codereview.webrtc.org/1858123003/ ) Reason for revert: Because of down-stream dependencies, this CL needs to be reverted. The dependencies will be resolved and then the CL will be relanded. Original issue's description: > Revert "Revert of Moved ring-buffer related files from common_audio to audio_processing (patchset #8 id:150001 of https://codereview.webrtc.org/1846903004/ )" > > This reverts commit c54aad6ae07fe2a44a65be403386bd7d7d865e5b. > > BUG=webrtc:5724 > NOPRESUBMIT=true > > Committed: https://crrev.com/8864fe5e08f8d8711612526dee9a812adfcd3be1 > Cr-Commit-Position: refs/heads/master@{#12247} TBR=henrik.lundin@webrtc.org,ivoc@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:5724 Committed: https://crrev.com/faed4ab24bf76fbcaa84f231b9cf0cc019e3df8a Cr-Commit-Position: refs/heads/master@{#12248}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1850 lines, -1903 lines) Patch
M webrtc/common_audio/BUILD.gn View 3 chunks +8 lines, -0 lines 0 comments Download
M webrtc/common_audio/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/common_audio/audio_ring_buffer.h View 2 chunks +42 lines, -3 lines 0 comments Download
A webrtc/common_audio/audio_ring_buffer.cc View 1 chunk +75 lines, -0 lines 0 comments Download
A webrtc/common_audio/audio_ring_buffer_unittest.cc View 1 chunk +112 lines, -0 lines 0 comments Download
M webrtc/common_audio/blocker.h View 1 chunk +121 lines, -14 lines 0 comments Download
A webrtc/common_audio/blocker.cc View 1 chunk +236 lines, -0 lines 0 comments Download
A webrtc/common_audio/blocker_unittest.cc View 1 chunk +345 lines, -0 lines 0 comments Download
M webrtc/common_audio/common_audio.gyp View 4 chunks +9 lines, -0 lines 0 comments Download
M webrtc/common_audio/lapped_transform.h View 2 chunks +111 lines, -3 lines 0 comments Download
A webrtc/common_audio/lapped_transform.cc View 1 chunk +102 lines, -0 lines 0 comments Download
A webrtc/common_audio/lapped_transform_unittest.cc View 1 chunk +208 lines, -0 lines 0 comments Download
A webrtc/common_audio/ring_buffer.h View 1 chunk +66 lines, -0 lines 0 comments Download
A webrtc/common_audio/ring_buffer.c View 1 chunk +247 lines, -0 lines 0 comments Download
A webrtc/common_audio/ring_buffer_unittest.cc View 1 chunk +150 lines, -0 lines 0 comments Download
M webrtc/modules/audio_processing/BUILD.gn View 1 chunk +0 lines, -8 lines 0 comments Download
M webrtc/modules/audio_processing/aec/aec_core.cc View 2 chunks +3 lines, -1 line 0 comments Download
M webrtc/modules/audio_processing/aec/aec_core_internal.h View 1 chunk +3 lines, -4 lines 0 comments Download
M webrtc/modules/audio_processing/aec/echo_cancellation.cc View 1 chunk +1 line, -3 lines 0 comments Download
M webrtc/modules/audio_processing/aec/echo_cancellation_internal.h View 1 chunk +3 lines, -3 lines 0 comments Download
M webrtc/modules/audio_processing/aecm/aecm_core.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_processing/aecm/aecm_core.c View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_processing/aecm/aecm_core_c.c View 2 chunks +2 lines, -1 line 0 comments Download
M webrtc/modules/audio_processing/aecm/echo_control_mobile.c View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_processing/audio_processing.gypi View 1 chunk +0 lines, -8 lines 0 comments Download
M webrtc/modules/audio_processing/beamformer/nonlinear_beamformer.h View 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/modules/audio_processing/intelligibility/intelligibility_enhancer.h View 1 chunk +1 line, -1 line 0 comments Download
D webrtc/modules/audio_processing/utility/audio_ring_buffer.h View 1 chunk +0 lines, -55 lines 0 comments Download
D webrtc/modules/audio_processing/utility/audio_ring_buffer.cc View 1 chunk +0 lines, -75 lines 0 comments Download
D webrtc/modules/audio_processing/utility/audio_ring_buffer_unittest.cc View 1 chunk +0 lines, -113 lines 0 comments Download
D webrtc/modules/audio_processing/utility/blocker.h View 1 chunk +0 lines, -124 lines 0 comments Download
D webrtc/modules/audio_processing/utility/blocker.cc View 1 chunk +0 lines, -236 lines 0 comments Download
D webrtc/modules/audio_processing/utility/blocker_unittest.cc View 1 chunk +0 lines, -345 lines 0 comments Download
D webrtc/modules/audio_processing/utility/lapped_transform.h View 1 chunk +0 lines, -124 lines 0 comments Download
D webrtc/modules/audio_processing/utility/lapped_transform.cc View 1 chunk +0 lines, -102 lines 0 comments Download
D webrtc/modules/audio_processing/utility/lapped_transform_unittest.cc View 1 chunk +0 lines, -208 lines 0 comments Download
D webrtc/modules/audio_processing/utility/ring_buffer.h View 1 chunk +0 lines, -66 lines 0 comments Download
D webrtc/modules/audio_processing/utility/ring_buffer.c View 1 chunk +0 lines, -247 lines 0 comments Download
D webrtc/modules/audio_processing/utility/ring_buffer_unittest.cc View 1 chunk +0 lines, -150 lines 0 comments Download
M webrtc/modules/modules.gyp View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
peah-webrtc
Created Revert of Moved ring-buffer related files from common_audio to audio_processing"
4 years, 8 months ago (2016-04-05 21:57:33 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1855393004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1855393004/1
4 years, 8 months ago (2016-04-05 21:57:37 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-05 21:57:51 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/faed4ab24bf76fbcaa84f231b9cf0cc019e3df8a Cr-Commit-Position: refs/heads/master@{#12248}
4 years, 8 months ago (2016-04-05 21:58:00 UTC) #6
ivoc
lgtm
4 years, 8 months ago (2016-04-06 07:28:29 UTC) #7
hlundin-webrtc
4 years, 8 months ago (2016-04-06 11:14:30 UTC) #8
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698