Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Issue 1855373005: Remove .def files from GYP and GN in webrtc/base (Closed)

Created:
4 years, 8 months ago by kjellander_webrtc
Modified:
4 years, 8 months ago
Reviewers:
perkj_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove .def files from GYP and GN in webrtc/base This was previously done in https://webrtc-codereview.appspot.com/49969004 but was accidentally readded in https://codereview.webrtc.org/1857163003/ .def files breaks downstream since it's not a recognized file extension. BUG=webrtc:4256 TBR=perkj@webrtc.org Committed: https://crrev.com/c1dba730282e5e33c0b8a19bbc5ebcefc1982f18 Cr-Commit-Position: refs/heads/master@{#12243}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M webrtc/base/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/base/base.gyp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
kjellander_webrtc
4 years, 8 months ago (2016-04-05 15:31:21 UTC) #1
kjellander_webrtc
Committed patchset #1 (id:1) manually as c1dba730282e5e33c0b8a19bbc5ebcefc1982f18 (presubmit successful).
4 years, 8 months ago (2016-04-05 15:31:37 UTC) #3
commit-bot: I haz the power
4 years, 8 months ago (2016-04-05 15:31:40 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c1dba730282e5e33c0b8a19bbc5ebcefc1982f18
Cr-Commit-Position: refs/heads/master@{#12243}

Powered by Google App Engine
This is Rietveld 408576698