Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 1854413004: Remove latency-based frame dropping on Android. (Closed)

Created:
4 years, 8 months ago by pbos-webrtc
Modified:
4 years, 8 months ago
Reviewers:
AlexG, stefan-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove latency-based frame dropping on Android. This logic currently prevents loopback calls on Nexus 5X when it's slightly overloaded to maintain input framerate since encoding at ~25fps with one framedrop results in >70ms between frames naturally. With this change applied Nexus 5X can maintain ~25fps both in and out without building excessive latency (>2 frames) (this is now covered by CPU adaptation outside the codec wrapper). BUG= R=glaznev@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/f7704d197b16ec4df06b6353daeea3da0f3c090b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -24 lines) Patch
M webrtc/api/java/jni/androidmediaencoder_jni.cc View 2 chunks +17 lines, -24 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
pbos-webrtc
PTAL, this fixes Nexus 5X loopback performance (though it's still CPU loaded, and has trouble ...
4 years, 8 months ago (2016-04-06 14:51:31 UTC) #1
AlexG
lgtm Please also consider an option to boost latency threshold to 150 ms - it ...
4 years, 8 months ago (2016-04-06 19:30:41 UTC) #2
pbos-webrtc
On 2016/04/06 19:30:41, AlexG wrote: > lgtm > > Please also consider an option to ...
4 years, 8 months ago (2016-04-11 14:42:34 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f7704d197b16ec4df06b6353daeea3da0f3c090b Cr-Commit-Position: refs/heads/master@{#12317}
4 years, 8 months ago (2016-04-11 14:42:52 UTC) #6
pbos-webrtc
4 years, 8 months ago (2016-04-11 14:42:55 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f7704d197b16ec4df06b6353daeea3da0f3c090b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698