Objective C API to read and set RtpParameters

webrtc/api/objc/RTCRtpEncodingParameters.mm

+/*
+ *  Copyright 2016 The WebRTC project authors. All Rights Reserved.
+ *
+ *  Use of this source code is governed by a BSD-style license
+ *  that can be found in the LICENSE file in the root of the source
+ *  tree. An additional intellectual property rights grant can be found
+ *  in the file PATENTS.  All contributing project authors may
+ *  be found in the AUTHORS file in the root of the source tree.
+ */
+
+#import "RTCRtpEncodingParameters+Private.h"
+
+@implementation RTCRtpEncodingParameters
+
+@synthesize maxBitrateBps = _maxBitrateBps;
+@synthesize active = _active;
+
+const int kBitrateUnlimited = -1;

[tkchin_webrtc, 2016/04/05 18:48:15]

no namespace, so either static linkage or prefix:
RTCRtpEncodingParametersBitrateUnlimited

[skvlad, 2016/04/05 23:21:27]

Made static.

+
+- (webrtc::RtpEncodingParameters)nativeParameters {
+  webrtc::RtpEncodingParameters parameters;
+  parameters.active = self.active;

[tkchin_webrtc, 2016/04/05 18:48:15]

usually we just access instance variable directly if it's nonatomic. _active

[skvlad, 2016/04/05 23:21:28]

Done.

+  if (self.maxBitrateBps != nil) {
+    parameters.max_bitrate_bps = [self.maxBitrateBps intValue];
+  }
+  return parameters;
+}
+
+- (instancetype)initWithNativeParameters:
+    (const webrtc::RtpEncodingParameters&)nativeParameters {
+  if (self = [super init]) {
+    if (nativeParameters.max_bitrate_bps != kBitrateUnlimited) {

[tkchin_webrtc, 2016/04/05 18:48:15]

isn't there a C++ equivalent of unlimited bitrate? It would be good to stick
this kind of constant in C++ land.

[skvlad, 2016/04/05 23:21:27]

The C++ equivalent will be replaced with rtc::Optional in an upcoming CL. I'll
update this code then. Added a TODO for now.

+      self.maxBitrateBps =

[tkchin_webrtc, 2016/04/05 18:48:15]

ditto _maxBitrateBps = nativeParameters.max_bitrate_bps

[skvlad, 2016/04/05 23:21:27]

Done.

+          [NSNumber numberWithInt:nativeParameters.max_bitrate_bps];
+    } else {
+      self.maxBitrateBps = nil;
+    }
+    self.active = nativeParameters.active;
+  }
+  return self;
+}
+
+@end