webrtc/api/objc/RTCRtpEncodingParameters.h - Issue 1854393002: Objective C API to read and set RtpParameters

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: webrtc/api/objc/RTCRtpEncodingParameters.h

Issue 1854393002: Objective C API to read and set RtpParameters (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 /*	1 /*

2 * Copyright 2016 The WebRTC project authors. All Rights Reserved.	2 * Copyright 2016 The WebRTC project authors. All Rights Reserved.

3 *	3 *

4 * Use of this source code is governed by a BSD-style license	4 * Use of this source code is governed by a BSD-style license

5 * that can be found in the LICENSE file in the root of the source	5 * that can be found in the LICENSE file in the root of the source

6 * tree. An additional intellectual property rights grant can be found	6 * tree. An additional intellectual property rights grant can be found

7 * in the file PATENTS. All contributing project authors may	7 * in the file PATENTS. All contributing project authors may

8 * be found in the AUTHORS file in the root of the source tree.	8 * be found in the AUTHORS file in the root of the source tree.

9 */	9 */

10	10

11 #import <Foundation/Foundation.h>	11 #import <Foundation/Foundation.h>

12	12

13 #import "webrtc/base/objc/RTCMacros.h"	13 NS_ASSUME_NONNULL_BEGIN

14	14

15 /**	15 @interface RTCRtpEncodingParameters : NSObject

16 * Initialize and clean up the SSL library. Failure is fatal. These call the	16

17 * corresponding functions in webrtc/base/ssladapter.h.	17 @property(nonatomic, copy, nullable) NSNumber* maxBitrateBps;
	tkchin_webrtc 2016/04/05 18:48:15 not common to use NSNumber outside of collection c not common to use NSNumber outside of collection classes - just use whatever the underlying C++ type is. skvlad 2016/04/05 23:21:27 As discussed offline - this property contains an o Show quoted text On 2016/04/05 18:48:15, tkchin_webrtc wrote: > not common to use NSNumber outside of collection classes - just use whatever the > underlying C++ type is. As discussed offline - this property contains an optional value, and a nullable NSNumber seems to be appropriate. This corresponds to an rtc::Optional<int> in the C++ codebase.
18 */	18 @property(nonatomic, assign) BOOL active;
	Taylor Brandstetter 2016/04/05 17:48:03 nit: could put "active" first, since it's first el nit: could put "active" first, since it's first elsewhere. tkchin_webrtc 2016/04/05 18:48:15 ObjC style (at least in our codebase) is to prefix ObjC style (at least in our codebase) is to prefix bools with is/has/should BOOL isActive; skvlad 2016/04/05 23:21:27 Done. Show quoted text On 2016/04/05 18:48:15, tkchin_webrtc wrote: > ObjC style (at least in our codebase) is to prefix bools with is/has/should > BOOL isActive; Done. skvlad 2016/04/05 23:21:27 Done. Show quoted text On 2016/04/05 17:48:03, Taylor Brandstetter wrote: > nit: could put "active" first, since it's first elsewhere. Done.
19 RTC_EXPORT BOOL RTCInitializeSSL();	19

20 RTC_EXPORT BOOL RTCCleanupSSL();	20 - (instancetype)init NS_UNAVAILABLE;

	21

	22 @end

	23

	24 NS_ASSUME_NONNULL_END

OLD	NEW